Fix checkdeps.py to check all the source directories in git checkouts.

tools/checkdeps/checkdeps.py

Index: tools/checkdeps/checkdeps.py
diff --git a/tools/checkdeps/checkdeps.py b/tools/checkdeps/checkdeps.py
index b175beaf92cf209e92f59f6eeba322d33c56484a..dca995b1ac43f85830a4d89620e00d76550c2c6b 100755
--- a/tools/checkdeps/checkdeps.py
+++ b/tools/checkdeps/checkdeps.py
@@ -414,10 +414,12 @@ def GetGitSourceDirectory(root):
   git_source_directory = set()
   popen_out = os.popen("cd %s && git ls-files --full-name ." %
                        pipes.quote(root))
+  git_source_directory.add(root)
   for line in popen_out.readlines():
     dir_name = os.path.join(root, os.path.dirname(line))
-    git_source_directory.add(dir_name)
-  git_source_directory.add(root)
+    while dir_name not in git_source_directory:

[satorux1, 2011/10/27 22:03:48]

if dir_name is initially "foo/bar/baz", we'll add "foo/bar" and "foo" if needed,
right?

Would it be possible that "foo/bar" is already in git_source_directory, but
"foo" is not? If it's possible, this logic won't be able to add "foo". I guess
it'd be safer to always add all parent directories like

  while not dir_name:
    git_source_directory.add(dir_name)
    dir_name = os.path.dirname(dir_name)

assuming dir_name will eventually be empty.

[kinaba, 2011/10/27 22:30:14]

Yes.
It is impossible, because all additions are done through this logic; if it has
added "foo/bar", then surely it should have tried "foo" next.
But, yes, I agree this is more safer and easier to understand. It is a bit
slower (around 300ms on my machine in addition to the 100msec slowdown of the
first patch compared to the ToT version), but I guess it is tolerable in the
total running time of the script (6-7 sec).

+      git_source_directory.add(dir_name)
+      dir_name = os.path.dirname(dir_name)
   return git_source_directory