Fix checkdeps.py to check all the source directories in git checkouts.

tools/checkdeps/checkdeps.py

 #!/usr/bin/python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Makes sure that files include headers from allowed directories.
 
 Checks DEPS files in the source tree for rules, and applies those rules to
 "#include" commands in source files. Any source file including something not
 permitted by the DEPS files will fail.
@@ skipping 396 matching lines @@
 
   Args:
     root: The repository root where .git directory exists.
 
   Returns:
     A set of directories which contain sources managed by git.
   """
   git_source_directory = set()
   popen_out = os.popen("cd %s && git ls-files --full-name ." %
                        pipes.quote(root))
+  git_source_directory.add(root)
   for line in popen_out.readlines():
     dir_name = os.path.join(root, os.path.dirname(line))
-    git_source_directory.add(dir_name)
-  git_source_directory.add(root)
+    while dir_name not in git_source_directory:

[satorux1, 2011/10/27 22:03:48]

if dir_name is initially "foo/bar/baz", we'll add "foo/bar" and "foo" if needed,
right?

Would it be possible that "foo/bar" is already in git_source_directory, but
"foo" is not? If it's possible, this logic won't be able to add "foo". I guess
it'd be safer to always add all parent directories like

  while not dir_name:
    git_source_directory.add(dir_name)
    dir_name = os.path.dirname(dir_name)

assuming dir_name will eventually be empty.

[kinaba, 2011/10/27 22:30:14]

Yes.
It is impossible, because all additions are done through this logic; if it has
added "foo/bar", then surely it should have tried "foo" next.
But, yes, I agree this is more safer and easier to understand. It is a bit
slower (around 300ms on my machine in addition to the 100msec slowdown of the
first patch compared to the ToT version), but I guess it is tolerable in the
total running time of the script (6-7 sec).

+      git_source_directory.add(dir_name)
+      dir_name = os.path.dirname(dir_name)
   return git_source_directory
 
 
 def PrintUsage():
   print """Usage: python checkdeps.py [--root <root>] [tocheck]
   --root   Specifies the repository root. This defaults to "../../.." relative
            to the script file. This will be correct given the normal location
            of the script in "<root>/tools/checkdeps".
 
   tocheck  Specifies the directory, relative to root, to check. This defaults
@@ skipping 57 matching lines @@
 if '__main__' == __name__:
   option_parser = optparse.OptionParser()
   option_parser.add_option("", "--root", default="", dest="base_directory",
                            help='Specifies the repository root. This defaults '
                            'to "../../.." relative to the script file, which '
                            'will normally be the repository root.')
   option_parser.add_option("-v", "--verbose", action="store_true",
                            default=False, help="Print debug logging")
   options, args = option_parser.parse_args()
   main(options, args)