Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 8414035: Makes DefaultContainerLayoutManager ignore windows with transient (Closed)

Created:
9 years, 1 month ago by sky
Modified:
9 years, 1 month ago
CC:
chromium-reviews, tfarina, dhollowa
Visibility:
Public.

Description

Makes DefaultContainerLayoutManager ignore windows with transient parents. This is needed otherwise the worskpace code tries to place and position bubbles and other transient type windows. BUG=none TEST=none R=ben@chromium.org,oshima@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108006

Patch Set 1 #

Patch Set 2 : Add test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M ui/aura/window.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/aura_shell/default_container_layout_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/aura_shell/default_container_layout_manager_unittest.cc View 1 2 chunks +20 lines, -1 line 2 comments Download
M views/widget/native_widget_aura.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
9 years, 1 month ago (2011-10-28 22:58:11 UTC) #1
oshima
Thanks. Can you add a test for this?
9 years, 1 month ago (2011-10-28 23:18:48 UTC) #2
sky
Done. -Scott On Fri, Oct 28, 2011 at 4:18 PM, <oshima@chromium.org> wrote: > Thanks. Can ...
9 years, 1 month ago (2011-10-28 23:40:54 UTC) #3
oshima
LGTM
9 years, 1 month ago (2011-10-28 23:55:00 UTC) #4
Ben Goodger (Google)
lgtm http://codereview.chromium.org/8414035/diff/2001/ui/aura_shell/default_container_layout_manager_unittest.cc File ui/aura_shell/default_container_layout_manager_unittest.cc (right): http://codereview.chromium.org/8414035/diff/2001/ui/aura_shell/default_container_layout_manager_unittest.cc#newcode147 ui/aura_shell/default_container_layout_manager_unittest.cc:147: reinterpret_cast<void*>(Widget::InitParams::TYPE_WINDOW))); It seems like we should have a ...
9 years, 1 month ago (2011-10-31 18:24:27 UTC) #5
oshima
9 years, 1 month ago (2011-10-31 19:48:47 UTC) #6
http://codereview.chromium.org/8414035/diff/2001/ui/aura_shell/default_contai...
File ui/aura_shell/default_container_layout_manager_unittest.cc (right):

http://codereview.chromium.org/8414035/diff/2001/ui/aura_shell/default_contai...
ui/aura_shell/default_container_layout_manager_unittest.cc:147:
reinterpret_cast<void*>(Widget::InitParams::TYPE_WINDOW)));
On 2011/10/31 18:24:27, Ben Goodger (Google) wrote:
> It seems like we should have a utility function do this sort of thing more
> easily.

I'm adding Widow::SetIntProperty, which should be able to
simplify this.

Powered by Google App Engine
This is Rietveld 408576698