Makes DefaultContainerLayoutManager ignore windows with transient

ui/aura_shell/default_container_layout_manager_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura_shell/default_container_layout_manager.h"
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_vector.h"
 #include "ui/aura/test/aura_test_base.h"
@@ skipping 49 matching lines @@
                                     parent,
                                     Widget::InitParams::TYPE_WINDOW);
   }
 
   aura::Window* container() { return container_.get(); }
 
   DefaultContainerLayoutManager* default_container_layout_manager() {
     return workspace_controller_->layout_manager();
   }
 
- private:
+ protected:
   scoped_ptr<aura::Window> container_;
   ScopedVector<ui::ViewProp> props_;
   scoped_ptr<aura_shell::internal::WorkspaceController> workspace_controller_;
 
+ private:
   DISALLOW_COPY_AND_ASSIGN(DefaultContainerLayoutManagerTest);
 };
 
 }  // namespace
 
 #if !defined(OS_WIN)
 TEST_F(DefaultContainerLayoutManagerTest, SetBounds) {
   // Layout Manager moves the window to (0,0) to fit to draggable area.
   scoped_ptr<aura::Window> child(
       CreateTestWindow(gfx::Rect(0, -1000, 100, 100), container()));
@@ skipping 44 matching lines @@
 
   // A popup window can be moved to outside of draggable area.
   popup->SetBounds(gfx::Rect(-100, 0, 100, 100));
   EXPECT_EQ("-100,0 100x100", popup->bounds().ToString());
 
   // A popup window can be resized to the size bigger than draggable area.
   popup->SetBounds(gfx::Rect(0, 0, 1000, 1000));
   EXPECT_EQ("0,0 1000x1000", popup->bounds().ToString());
 }
 
+// Make sure a window with a transient parent isn't resized by the layout
+// manager.
+TEST_F(DefaultContainerLayoutManagerTest, IgnoreTransient) {
+  scoped_ptr<aura::Window> window(new aura::Window(NULL));
+  props_.push_back(
+      new ui::ViewProp(
+          window.get(), views::NativeWidgetAura::kWindowTypeKey,
+          reinterpret_cast<void*>(Widget::InitParams::TYPE_WINDOW)));

[Ben Goodger (Google), 2011/10/31 18:24:27]

It seems like we should have a utility function do this sort of thing more
easily.

[oshima, 2011/10/31 19:48:47]

I'm adding Widow::SetIntProperty, which should be able to
simplify this.

+  window->SetType(Widget::InitParams::TYPE_WINDOW);
+  window->Init(ui::Layer::LAYER_HAS_NO_TEXTURE);
+  aura::Desktop::GetInstance()->AddTransientChild(window.get());
+  window->SetBounds(gfx::Rect(0, 0, 200, 200));
+  window->Show();
+  window->SetParent(container());
+
+  EXPECT_EQ("0,0 200x200", window->bounds().ToString());
+}
+
 }  // namespace test
 }  // namespace aura_shell