Issue 8414024: Analyzed the problem and tested 30+ times the affected and related tests without problems. Test f...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8414024: Analyzed the problem and tested 30+ times the affected and related tests without problems. Test f... (Closed)

Created:
9 years, 1 month ago by Leandro Gracia Gil

Modified:
9 years, 1 month ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Analyzed the problem and tested 30+ times the affected and related tests without problems. Test failure seems to be a non-related flake. Revert 107727 - Revert 107722 - Implement notifications for the DisplayBalloon method on Linux and Mac. BUG=74970 TEST=install background app on window, see desktop notification. Review URL: http://codereview.chromium.org/8375027 TBR=leandrogracia@chromium.org Review URL: http://codereview.chromium.org/8417027 TBR=rohitrao@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107738

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -5 lines)			Patch
A +	chrome/browser/status_icons/desktop_notification_balloon.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/status_icons/desktop_notification_balloon.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/ui/cocoa/status_icons/status_icon_mac.h	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/status_icons/status_icon_mac.mm	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/status_icons/status_icon_gtk.h	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/status_icons/status_icon_gtk.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)