Issue 8417027: Revert 107722 - Implement notifications for the DisplayBalloon method on Linux and Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8417027: Revert 107722 - Implement notifications for the DisplayBalloon method on Linux and Mac. (Closed)

Created:
9 years, 1 month ago by rohitrao (ping after 24h)

Modified:
9 years, 1 month ago

Reviewers:
Leandro Graciá Gil

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 107722 - Implement notifications for the DisplayBalloon method on Linux and Mac. BUG=74970 TEST=install background app on window, see desktop notification. Review URL: http://codereview.chromium.org/8375027 TBR=leandrogracia@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107727

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -133 lines)			Patch
D	chrome/browser/status_icons/desktop_notification_balloon.h	View	1 chunk	+0 lines, -37 lines	0 comments	Download
D	chrome/browser/status_icons/desktop_notification_balloon.cc	View	1 chunk	+0 lines, -82 lines	0 comments	Download
M	chrome/browser/ui/cocoa/status_icons/status_icon_mac.h	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/status_icons/status_icon_mac.mm	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/status_icons/status_icon_gtk.h	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/ui/gtk/status_icons/status_icon_gtk.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

rohitrao (ping after 24h)

9 years, 1 month ago (2011-10-28 14:21:13 UTC) #2

Crash log on mac:
http://build.chromium.org/p/chromium/builders/Mac10.6%20Tests%20%282%29/build...