content/shell/shell_download_manager_delegate.cc - Issue 8414007: Rearrange Should*Download delegate calls to be more useful and intuitive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/shell_download_manager_delegate.cc

Issue 8414007: Rearrange Should*Download delegate calls to be more useful and intuitive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merged to TOT. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/shell_download_manager_delegate.cc

diff --git a/content/shell/shell_download_manager_delegate.cc b/content/shell/shell_download_manager_delegate.cc

index 1d6ec99dba5e9cdf1d139b891add11dbf221a571..01189144a1a21655e9164c37a31b61dfa4054617 100644

--- a/content/shell/shell_download_manager_delegate.cc

+++ b/content/shell/shell_download_manager_delegate.cc

@@ -152,11 +152,11 @@ bool ShellDownloadManagerDelegate::ShouldOpenFileBasedOnExtension(

return false;

}

-bool ShellDownloadManagerDelegate::ShouldOpenDownload(DownloadItem* item) {

+bool ShellDownloadManagerDelegate::ShouldCompleteDownload(DownloadItem* item) {

return true;

}

-bool ShellDownloadManagerDelegate::ShouldCompleteDownload(DownloadItem* item) {

+bool ShellDownloadManagerDelegate::ShouldOpenDownload(DownloadItem* item) {

return true;

}

« no previous file with comments | « content/shell/shell_download_manager_delegate.h ('k') | no next file » | no next file with comments »