Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: content/shell/shell_download_manager_delegate.cc

Issue 8414007: Rearrange Should*Download delegate calls to be more useful and intuitive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged to TOT. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/shell/shell_download_manager_delegate.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/shell/shell_download_manager_delegate.h" 5 #include "content/shell/shell_download_manager_delegate.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <commdlg.h> 9 #include <commdlg.h>
10 #endif 10 #endif
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 TabContents* ShellDownloadManagerDelegate:: 145 TabContents* ShellDownloadManagerDelegate::
146 GetAlternativeTabContentsToNotifyForDownload() { 146 GetAlternativeTabContentsToNotifyForDownload() {
147 return NULL; 147 return NULL;
148 } 148 }
149 149
150 bool ShellDownloadManagerDelegate::ShouldOpenFileBasedOnExtension( 150 bool ShellDownloadManagerDelegate::ShouldOpenFileBasedOnExtension(
151 const FilePath& path) { 151 const FilePath& path) {
152 return false; 152 return false;
153 } 153 }
154 154
155 bool ShellDownloadManagerDelegate::ShouldCompleteDownload(DownloadItem* item) {
156 return true;
157 }
158
155 bool ShellDownloadManagerDelegate::ShouldOpenDownload(DownloadItem* item) { 159 bool ShellDownloadManagerDelegate::ShouldOpenDownload(DownloadItem* item) {
156 return true; 160 return true;
157 } 161 }
158 162
159 bool ShellDownloadManagerDelegate::ShouldCompleteDownload(DownloadItem* item) {
160 return true;
161 }
162
163 bool ShellDownloadManagerDelegate::GenerateFileHash() { 163 bool ShellDownloadManagerDelegate::GenerateFileHash() {
164 return false; 164 return false;
165 } 165 }
166 166
167 void ShellDownloadManagerDelegate::OnResponseCompleted( 167 void ShellDownloadManagerDelegate::OnResponseCompleted(
168 DownloadItem* item, 168 DownloadItem* item,
169 const std::string& hash) { 169 const std::string& hash) {
170 } 170 }
171 171
172 void ShellDownloadManagerDelegate::AddItemToPersistentStore( 172 void ShellDownloadManagerDelegate::AddItemToPersistentStore(
(...skipping 27 matching lines...) Expand all
200 void ShellDownloadManagerDelegate::ChooseSavePath( 200 void ShellDownloadManagerDelegate::ChooseSavePath(
201 const base::WeakPtr<SavePackage>& save_package, 201 const base::WeakPtr<SavePackage>& save_package,
202 const FilePath& suggested_path, 202 const FilePath& suggested_path,
203 bool can_save_as_complete) { 203 bool can_save_as_complete) {
204 } 204 }
205 205
206 void ShellDownloadManagerDelegate::DownloadProgressUpdated() { 206 void ShellDownloadManagerDelegate::DownloadProgressUpdated() {
207 } 207 }
208 208
209 } // namespace content 209 } // namespace content
OLDNEW
« no previous file with comments | « content/shell/shell_download_manager_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698