wstring cleanup in browser/ui/login

wstring removal/cleanup in browser/ui/login

BUG=23581
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108016

[Elliot Glaysher, 2011-10-31 19:08:27]

http://codereview.chromium.org/8413022/diff/1/chrome/browser/ui/login/login_p...
File chrome/browser/ui/login/login_prompt_ui.cc (right):

http://codereview.chromium.org/8413022/diff/1/chrome/browser/ui/login/login_p...
chrome/browser/ui/login/login_prompt_ui.cc:224: autofill_username_ =
UTF16ToUTF8(username);
Looking at this final consumer, should all of this be converted to utf8 instead
of utf16?

[(unused - use chromium), 2011-10-31 19:15:08]

lgtm

http://codereview.chromium.org/8413022/diff/1/chrome/browser/ui/login/login_p...
File chrome/browser/ui/login/login_prompt_ui.cc (right):

http://codereview.chromium.org/8413022/diff/1/chrome/browser/ui/login/login_p...
chrome/browser/ui/login/login_prompt_ui.cc:224: autofill_username_ =
UTF16ToUTF8(username);
On 2011/10/31 19:08:27, Elliot Glaysher wrote:
> Looking at this final consumer, should all of this be converted to utf8
instead
> of utf16?

No, we don't want to pass text around in utf8 for long 'cause it's too easy to
get wrong.

[Elliot Glaysher, 2011-10-31 19:18:29]

http://codereview.chromium.org/8413022/diff/1/chrome/browser/ui/login/login_p...
File chrome/browser/ui/login/login_prompt_ui.cc (right):

http://codereview.chromium.org/8413022/diff/1/chrome/browser/ui/login/login_p...
chrome/browser/ui/login/login_prompt_ui.cc:224: autofill_username_ =
UTF16ToUTF8(username);
On 2011/10/31 19:15:09, thakis wrote:
> On 2011/10/31 19:08:27, Elliot Glaysher wrote:
> > Looking at this final consumer, should all of this be converted to utf8
> instead
> > of utf16?
> 
> No, we don't want to pass text around in utf8 for long 'cause it's too easy to
> get wrong.

ok lgtm then.

[tony, 2011-10-31 19:51:15]

http://codereview.chromium.org/8413022/diff/1/chrome/browser/ui/login/login_p...
File chrome/browser/ui/login/login_prompt_ui.cc (right):

http://codereview.chromium.org/8413022/diff/1/chrome/browser/ui/login/login_p...
chrome/browser/ui/login/login_prompt_ui.cc:224: autofill_username_ =
UTF16ToUTF8(username);
On 2011/10/31 19:18:29, Elliot Glaysher wrote:
> On 2011/10/31 19:15:09, thakis wrote:
> > On 2011/10/31 19:08:27, Elliot Glaysher wrote:
> > > Looking at this final consumer, should all of this be converted to utf8
> > instead
> > > of utf16?
> > 
> > No, we don't want to pass text around in utf8 for long 'cause it's too easy
to
> > get wrong.
> 
> ok lgtm then.

I ended up changing autofill_username_ and autofill_password_ to string16 since
they're just passed to a StringValue which takes either utf8 or string16.

[(unused - use chromium), 2011-10-31 19:55:42]

lbtm

[(unused - use chromium), 2011-10-31 19:56:09]

On 2011/10/31 19:55:42, thakis wrote:
> lbtm

(I just realized that that's ambiguous. "better", not "bad".)

[commit-bot: I haz the power, 2011-10-31 20:26:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/8413022/5001

[commit-bot: I haz the power, 2011-10-31 21:49:58]

Change committed as 108016