Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6293)

Unified Diff: chrome/browser/ui/login/login_prompt_browsertest.cc

Issue 8413022: wstring cleanup in browser/ui/login (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: better Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/login/login_model.h ('k') | chrome/browser/ui/login/login_prompt_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/login/login_prompt_browsertest.cc
diff --git a/chrome/browser/ui/login/login_prompt_browsertest.cc b/chrome/browser/ui/login/login_prompt_browsertest.cc
index 972d9d28365034b2b5478e0e44e377fb13b6b53e..cb09a10cbc05d2459fa86545799b721431242280 100644
--- a/chrome/browser/ui/login/login_prompt_browsertest.cc
+++ b/chrome/browser/ui/login/login_prompt_browsertest.cc
@@ -26,22 +26,22 @@ namespace {
class LoginPromptBrowserTest : public InProcessBrowserTest {
public:
LoginPromptBrowserTest()
- : bad_password_(L"incorrect"), bad_username_(L"nouser") {
+ : bad_password_("incorrect"), bad_username_("nouser") {
set_show_window(true);
- auth_map_["foo"] = AuthInfo(L"testuser", L"foopassword");
- auth_map_["bar"] = AuthInfo(L"testuser", L"barpassword");
+ auth_map_["foo"] = AuthInfo("testuser", "foopassword");
+ auth_map_["bar"] = AuthInfo("testuser", "barpassword");
}
protected:
struct AuthInfo {
- std::wstring username_;
- std::wstring password_;
+ std::string username_;
+ std::string password_;
AuthInfo() {}
- AuthInfo(const std::wstring username,
- const std::wstring password)
+ AuthInfo(const std::string username,
+ const std::string password)
: username_(username), password_(password) {}
};
@@ -50,8 +50,8 @@ class LoginPromptBrowserTest : public InProcessBrowserTest {
void SetAuthFor(LoginHandler* handler);
AuthMap auth_map_;
- std::wstring bad_password_;
- std::wstring bad_username_;
+ std::string bad_password_;
+ std::string bad_username_;
};
void LoginPromptBrowserTest::SetAuthFor(LoginHandler* handler) {
@@ -62,8 +62,8 @@ void LoginPromptBrowserTest::SetAuthFor(LoginHandler* handler) {
EXPECT_TRUE(auth_map_.end() != i);
if (i != auth_map_.end()) {
const AuthInfo& info = i->second;
- handler->SetAuth(WideToUTF16Hack(info.username_),
- WideToUTF16Hack(info.password_));
+ handler->SetAuth(UTF8ToUTF16(info.username_),
+ UTF8ToUTF16(info.password_));
}
}
@@ -491,8 +491,8 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, IncorrectConfirmation) {
LoginHandler* handler = *observer.handlers_.begin();
ASSERT_TRUE(handler);
- handler->SetAuth(WideToUTF16Hack(bad_username_),
- WideToUTF16Hack(bad_password_));
+ handler->SetAuth(UTF8ToUTF16(bad_username_),
+ UTF8ToUTF16(bad_password_));
auth_supplied_waiter.Wait();
// The request should be retried after the incorrect password is
« no previous file with comments | « chrome/browser/ui/login/login_model.h ('k') | chrome/browser/ui/login/login_prompt_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698