Issue 8413019: Fix vorbis decoder bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8413019: Fix vorbis decoder bug. (Closed)

Created:
9 years, 1 month ago by Chris Evans

Modified:
9 years, 1 month ago

Reviewers:
rbultje1

CC:
chromium-reviews, scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/ffmpeg/

Visibility:
Public.

Description

Fix vorbis decoder bug. BUG=101458 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107662

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -1 line)			Patch
M	README.chromium	View	2 chunks	+13 lines, -0 lines	1 comment	Download
M	patches/README	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	patches/to_upstream/48_vorbis_residue_buffer.patch	View	1 chunk	+35 lines, -0 lines	0 comments	Download
M	source/patched-ffmpeg/libavcodec/vorbisdec.c	View	3 chunks	+7 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rbultje1

Almost LGTM. ;). http://codereview.chromium.org/8413019/diff/1/README.chromium File README.chromium (right): http://codereview.chromium.org/8413019/diff/1/README.chromium#newcode65 README.chromium:65: patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/45_mkv_fix_segmap_cache_overflow.patch vp8, ...

9 years, 1 month ago (2011-10-27 23:36:13 UTC) #2

rbultje1

9 years, 1 month ago (2011-10-27 23:37:59 UTC) #3

On 2011/10/27 23:36:13, rbultje1 wrote:
> Almost LGTM. ;).
> 
> http://codereview.chromium.org/8413019/diff/1/README.chromium
> File README.chromium (right):
> 
> http://codereview.chromium.org/8413019/diff/1/README.chromium#newcode65
> README.chromium:65: patch -p1 --no-backup-if-mismatch <
> ../patches/to_upstream/45_mkv_fix_segmap_cache_overflow.patch
> vp8, not mkv :)

Oh wait that's my typo not yours, nevermind then. LGTM.

Expand Messages | Collapse Messages