Chromium Code Reviews Chromium Code Reviews
Issue 8413019:
Fix vorbis decoder bug. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/ffmpeg/| OLD | NEW |
|---|---|
| 1 Name: ffmpeg | 1 Name: ffmpeg |
| 2 Version: 0.9.7 | 2 Version: 0.9.7 |
| 3 | 3 |
| 4 Description: | 4 Description: |
| 5 Contains the sources used to compile FFmpeg binaries used by Google Chrome and | 5 Contains the sources used to compile FFmpeg binaries used by Google Chrome and |
| 6 Chromium. | 6 Chromium. |
| 7 | 7 |
| 8 The FFmpeg source is from ToT of the main ffmpeg branch: | 8 The FFmpeg source is from ToT of the main ffmpeg branch: |
| 9 http://git.videolan.org/?p=ffmpeg.git;a=commit;h=bb258fb995a42112d1fe14f53ec59 9b2cd19b707 | 9 http://git.videolan.org/?p=ffmpeg.git;a=commit;h=bb258fb995a42112d1fe14f53ec59 9b2cd19b707 |
| 10 Date: Tue, 12 Jul 2011 22:42:11 | 10 Date: Tue, 12 Jul 2011 22:42:11 |
| (...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 54 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/34_ogg_memcpy. patch | 54 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/34_ogg_memcpy. patch |
| 55 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/35_oggdec_dura tion.patch | 55 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/35_oggdec_dura tion.patch |
| 56 patch -p1 --no-backup-if-mismatch < ../patches/from_upstream/36_theora_fl ush.patch | 56 patch -p1 --no-backup-if-mismatch < ../patches/from_upstream/36_theora_fl ush.patch |
| 57 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/37_VP8_armv6_o ptimizations.patch | 57 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/37_VP8_armv6_o ptimizations.patch |
| 58 patch -p1 --no-backup-if-mismatch < ../patches/from_upstream/38_webm_cues _before_first_cluster.patch | 58 patch -p1 --no-backup-if-mismatch < ../patches/from_upstream/38_webm_cues _before_first_cluster.patch |
| 59 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/39_VP8_fix_oob _read_writes.patch | 59 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/39_VP8_fix_oob _read_writes.patch |
| 60 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/40_MKV_fix_oob _write.patch | 60 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/40_MKV_fix_oob _write.patch |
| 61 patch -p1 --no-backup-if-mismatch < ../patches/ugly/41_matroska_cluster_i ncremental.patch | 61 patch -p1 --no-backup-if-mismatch < ../patches/ugly/41_matroska_cluster_i ncremental.patch |
| 62 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/42_vp8_fix_seg mentation_maps.patch | 62 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/42_vp8_fix_seg mentation_maps.patch |
| 63 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/43_mkv_seekahe ad_revalidate.patch | 63 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/43_mkv_seekahe ad_revalidate.patch |
| 64 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/44_vorbis_oob_ read.patch | |
| 65 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/45_mkv_fix_seg map_cache_overflow.patch | |
|
rbultje1
2011/10/27 23:36:13
vp8, not mkv :)
| |
| 66 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/46_vp3_fix_dou ble_free_invalid_read.patch | |
| 67 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/47_vp3_fix_inf loop_and_memleak.patch | |
| 68 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/48_vorbis_resi due_buffer.patch | |
| 64 cd .. | 69 cd .. |
| 65 | 70 |
| 66 | 71 |
| 67 NOTE: Under Windows it is recommended to use Chromium's MinGW/MSYS environment | 72 NOTE: Under Windows it is recommended to use Chromium's MinGW/MSYS environment |
| 68 or 7-Zip to extract the archives. We've experienced issues when using WinRAR. | 73 or 7-Zip to extract the archives. We've experienced issues when using WinRAR. |
| 69 | 74 |
| 70 Since FFmpeg is sandboxed inside the render process, we're only interested in | 75 Since FFmpeg is sandboxed inside the render process, we're only interested in |
| 71 building the absolute minimum. | 76 building the absolute minimum. |
| 72 | 77 |
| 73 Refer to build_ffmpeg.sh for configuration flags for Chromium and Google Chrome. | 78 Refer to build_ffmpeg.sh for configuration flags for Chromium and Google Chrome. |
| (...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 304 diff -wurp -N orig ffmpeg >patches/to_upstream/46_vp3_fix_double_free_inv alid_read.patch | 309 diff -wurp -N orig ffmpeg >patches/to_upstream/46_vp3_fix_double_free_inv alid_read.patch |
| 305 | 310 |
| 306 rm -rf orig | 311 rm -rf orig |
| 307 cp -R ffmpeg orig | 312 cp -R ffmpeg orig |
| 308 cd ffmpeg | 313 cd ffmpeg |
| 309 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/47_vp3_fix_inf loop_and_memleak.patch | 314 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/47_vp3_fix_inf loop_and_memleak.patch |
| 310 cd .. | 315 cd .. |
| 311 diff -wurp -N orig ffmpeg | 316 diff -wurp -N orig ffmpeg |
| 312 diff -wurp -N orig ffmpeg >patches/to_upstream/47_vp3_fix_infloop_and_mem leak.patch | 317 diff -wurp -N orig ffmpeg >patches/to_upstream/47_vp3_fix_infloop_and_mem leak.patch |
| 313 | 318 |
| 319 rm -rf orig | |
| 320 cp -R ffmpeg orig | |
| 321 cd ffmpeg | |
| 322 patch -p1 --no-backup-if-mismatch < ../patches/to_upstream/48_vorbis_resi due_buffer.patch | |
| 323 cd .. | |
| 324 diff -wurp -N orig ffmpeg | |
| 325 diff -wurp -N orig ffmpeg >patches/to_upstream/48_vorbis_residue_buffer.p atch | |
| 326 | |
| 314 Testing | 327 Testing |
| 315 Updates should be tested against | 328 Updates should be tested against |
| 316 a) http://wiki.xiph.org/TheoraTestsuite | 329 a) http://wiki.xiph.org/TheoraTestsuite |
| 317 b) WebKit Layout Tests | 330 b) WebKit Layout Tests |
| 318 http://www.chromium.org/developers/testing/webkit-layout-tests | 331 http://www.chromium.org/developers/testing/webkit-layout-tests |
| 319 make -r test_shell BUILDTYPE=Debug -j16 | 332 make -r test_shell BUILDTYPE=Debug -j16 |
| 320 make -r ImageDiff BUILDTYPE=Debug -j16 | 333 make -r ImageDiff BUILDTYPE=Debug -j16 |
| 321 make -r DumpRenderTree BUILDTYPE=Debug -j16 | 334 make -r DumpRenderTree BUILDTYPE=Debug -j16 |
| 322 ./webkit/tools/layout_tests/run_webkit_tests.sh --debug media/\* | 335 ./webkit/tools/layout_tests/run_webkit_tests.sh --debug media/\* |
| OLD | NEW |
