Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 8409004: Force-setting default browser through policy should not crash. (Closed)

Created:
9 years, 1 month ago by benwells
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Force-setting default browser through policy should not crash. The call to set chrome as default browser due to policy needs to happen on the FILE thread. This change affects the call to set the default browser due to policy at startup and during runtime. BUG=101331 TEST=Manual testing performed Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M chrome/browser/browser_process_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
Reproduced problem and fixed. Not sure if the call to set default browser in response ...
9 years, 1 month ago (2011-10-31 05:58:34 UTC) #1
Mattias Nissler (ping if slow)
LGTM. Regarding setting the default browser on PREF_CHANGED notification, you are right with also moving ...
9 years, 1 month ago (2011-10-31 07:58:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/8409004/1
9 years, 1 month ago (2011-11-01 00:20:16 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-01 02:02:13 UTC) #4
Change committed as 108059

Powered by Google App Engine
This is Rietveld 408576698