Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 8409004: Force-setting default browser through policy should not crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_process_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index 5a3a0ef22b53472303dafd54762e3a15e195a5bb..0623619f4748eb7515a28e2c423167bc5bcdd488 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -682,8 +682,7 @@ void BrowserProcessImpl::Observe(int type,
if (type == chrome::NOTIFICATION_PREF_CHANGED) {
std::string* pref = content::Details<std::string>(details).ptr();
if (*pref == prefs::kDefaultBrowserSettingEnabled) {
- if (local_state_->GetBoolean(prefs::kDefaultBrowserSettingEnabled))
- ShellIntegration::SetAsDefaultBrowser();
+ ApplyDefaultBrowserPolicy();
} else if (*pref == prefs::kDisabledSchemes) {
ApplyDisabledSchemesPolicy();
} else if (*pref == prefs::kAllowCrossOriginAuthPrompt) {
@@ -940,8 +939,7 @@ void BrowserProcessImpl::CreateLocalState() {
local_state_->RegisterBooleanPref(prefs::kDefaultBrowserSettingEnabled,
false);
if (local_state_->IsManagedPreference(prefs::kDefaultBrowserSettingEnabled)) {
- if (local_state_->GetBoolean(prefs::kDefaultBrowserSettingEnabled))
- ShellIntegration::SetAsDefaultBrowser();
+ ApplyDefaultBrowserPolicy();
}
pref_change_registrar_.Add(prefs::kDefaultBrowserSettingEnabled, this);
@@ -1059,6 +1057,14 @@ void BrowserProcessImpl::ApplyDisabledSchemesPolicy() {
ChildProcessSecurityPolicy::GetInstance()->RegisterDisabledSchemes(schemes);
}
+void BrowserProcessImpl::ApplyDefaultBrowserPolicy() {
+ if (local_state_->GetBoolean(prefs::kDefaultBrowserSettingEnabled)) {
+ scoped_refptr<ShellIntegration::DefaultWebClientWorker>
+ set_browser_worker = new ShellIntegration::DefaultBrowserWorker(NULL);
+ set_browser_worker->StartSetAsDefault();
+ }
+}
+
void BrowserProcessImpl::ApplyAllowCrossOriginAuthPromptPolicy() {
bool value = local_state()->GetBoolean(prefs::kAllowCrossOriginAuthPrompt);
resource_dispatcher_host()->set_allow_cross_origin_auth_prompt(value);
« no previous file with comments | « chrome/browser/browser_process_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698