Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8404007: Delete code for and references to mini-gallery and theme install bubbles. (Closed)

Created:
9 years, 1 month ago by Yoyo Zhou
Modified:
9 years, 1 month ago
CC:
chromium-reviews, jennb, Erik does not do reviews, Dmitry Titov, prasadt, dcheng, mihaip+watch_chromium.org, Aaron Boodman, jianli, Paweł Hajdan Jr.
Visibility:
Public.

Description

Delete code for and references to mini-gallery and theme install bubbles. As of July, the mini-gallery simply redirects to the web store (b/4990237). BUG=101405 TEST=no user-visible changes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107527

Patch Set 1 #

Total comments: 4

Patch Set 2 : mihaip's #

Patch Set 3 : > #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -858 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/download/download_crx_util.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 chunks +1 line, -23 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
D chrome/browser/ui/cocoa/theme_install_bubble_view.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/ui/cocoa/theme_install_bubble_view.mm View 1 chunk +0 lines, -190 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
D chrome/browser/ui/gtk/theme_install_bubble_view_gtk.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/ui/gtk/theme_install_bubble_view_gtk.cc View 1 chunk +0 lines, -192 lines 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
D chrome/browser/ui/views/theme_install_bubble_view.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/ui/views/theme_install_bubble_view.cc View 1 chunk +0 lines, -172 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 4 chunks +0 lines, -8 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/static/themes.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/themes.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yoyo Zhou
9 years, 1 month ago (2011-10-26 21:49:01 UTC) #1
Mihai Parparita -not on Chrome
http://codereview.chromium.org/8404007/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/8404007/diff/1/chrome/browser/ui/browser.cc#newcode4305 chrome/browser/ui/browser.cc:4305: case chrome::NOTIFICATION_EXTENSION_READY_FOR_INSTALL: { Seems like this whole case statement ...
9 years, 1 month ago (2011-10-26 21:59:55 UTC) #2
Yoyo Zhou
http://codereview.chromium.org/8404007/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/8404007/diff/1/chrome/browser/ui/browser.cc#newcode4305 chrome/browser/ui/browser.cc:4305: case chrome::NOTIFICATION_EXTENSION_READY_FOR_INSTALL: { On 2011/10/26 21:59:55, Mihai Parparita wrote: ...
9 years, 1 month ago (2011-10-26 22:22:45 UTC) #3
Mihai Parparita -not on Chrome
9 years, 1 month ago (2011-10-26 22:33:53 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698