Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: chrome/browser/ui/browser.cc

Issue 8404007: Delete code for and references to mini-gallery and theme install bubbles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: > Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/ui/browser_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index b41d1306e6ffa3a1cbd361433dcbb497f388e92c..50450606f26c6f0484168043fb622d40f81a9cc1 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -313,10 +313,6 @@ Browser::Browser(Type type, Profile* profile)
registrar_.Add(this, chrome::NOTIFICATION_TAB_CONTENT_SETTINGS_CHANGED,
content::NotificationService::AllSources());
- // Need to know when to alert the user of theme install delay.
- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_READY_FOR_INSTALL,
- content::NotificationService::AllSources());
-
PrefService* local_state = g_browser_process->local_state();
if (local_state) {
local_pref_registrar_.Init(local_state);
@@ -3782,8 +3778,7 @@ void Browser::OnStartDownload(TabContents* source, DownloadItem* download) {
// window is minimized, we're in a unit test, etc.).
TabContents* shelf_tab = shelf->browser()->GetSelectedTabContents();
if ((download->total_bytes() > 0) &&
- (!ChromeDownloadManagerDelegate::IsExtensionDownload(download) ||
- ExtensionService::IsDownloadFromMiniGallery(download->GetURL())) &&
+ !ChromeDownloadManagerDelegate::IsExtensionDownload(download) &&
platform_util::IsVisible(shelf_tab->GetNativeView()) &&
ui::Animation::ShouldRenderRichAnimation()) {
DownloadStartedAnimation::Show(shelf_tab);
@@ -4304,23 +4299,6 @@ void Browser::Observe(int type,
window()->UserChangedTheme();
break;
- case chrome::NOTIFICATION_EXTENSION_READY_FOR_INSTALL: {
- Profile* profile = content::Source<Profile>(source).ptr();
- if (profile_->IsSameProfile(profile)) {
- // Handle EXTENSION_READY_FOR_INSTALL for last active tabbed browser.
- if (BrowserList::FindTabbedBrowser(profile, true) == this) {
- // We only want to show the loading dialog for themes, but we don't
- // want to wait until unpack to find out an extension is a theme, so
- // we test the download_url GURL instead. This means that themes in
- // the extensions gallery won't get the loading dialog.
- GURL download_url = *(content::Details<GURL>(details).ptr());
- if (ExtensionService::IsDownloadFromMiniGallery(download_url))
- window()->ShowThemeInstallBubble();
- }
- }
- break;
- }
-
case chrome::NOTIFICATION_PREF_CHANGED: {
const std::string& pref_name =
*content::Details<std::string>(details).ptr();
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/ui/browser_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698