Set extension-related webkit preferences in a common location.

content/browser/tab_contents/tab_contents.cc

Index: content/browser/tab_contents/tab_contents.cc
diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc
index fd84d52269e46fcb6c3ce231441186059c69411c..8e112997c09e1c65883daac0d13660566b35c226 100644
--- a/content/browser/tab_contents/tab_contents.cc
+++ b/content/browser/tab_contents/tab_contents.cc
@@ -1798,9 +1798,11 @@ void TabContents::RunBeforeUnloadConfirm(const RenderViewHost* rvh,
 }
 
 WebPreferences TabContents::GetWebkitPrefs() {
+  // TODO(aa): It seems like ths should pass |true| if this tab_contents has a
+  // web_ui, doesn't it?

[jam, 2011/10/27 17:10:24]

you can just do
(ChildProcessSecurityPolicy::GetInstance()->HasWebUIBindings(rvh->process()->id())

[Aaron Boodman, 2011/10/27 22:47:23]

Ok, but isn't it a bug in current Chrome that it doesn't do something like that?

[jam, 2011/10/28 16:20:50]

I don't understand what you mean? I thought you were asking if it's ok to make
GetWebkitPrefs take one less parameter if it's redundant. I agree since the
second parameter can be figured out from the first. so can we take it out?

   WebPreferences web_prefs =
       content::GetContentClient()->browser()->GetWebkitPrefs(
-          render_view_host()->process()->browser_context(), false);
+          render_view_host(), false);
 
   // Force accelerated compositing and 2d canvas off for chrome:, about: and
   // chrome-devtools: pages (unless it's specifically allowed).
@@ -2006,4 +2008,3 @@ bool TabContents::GotResponseToLockMouseRequest(bool allowed) {
   return render_view_host() ?
       render_view_host()->GotResponseToLockMouseRequest(allowed) : false;
 }
-