Set extension-related webkit preferences in a common location.

content/browser/tab_contents/tab_contents.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/tab_contents/tab_contents.h"
 
 #include <cmath>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
@@ skipping 1780 matching lines @@
   }
 
   is_showing_before_unload_dialog_ = true;
   dialog_creator_ = delegate_->GetJavaScriptDialogCreator();
   dialog_creator_->RunBeforeUnloadDialog(this,
                                          message,
                                          reply_msg);
 }
 
 WebPreferences TabContents::GetWebkitPrefs() {
+  // TODO(aa): It seems like ths should pass |true| if this tab_contents has a
+  // web_ui, doesn't it?

[jam, 2011/10/27 17:10:24]

you can just do
(ChildProcessSecurityPolicy::GetInstance()->HasWebUIBindings(rvh->process()->id())

[Aaron Boodman, 2011/10/27 22:47:23]

Ok, but isn't it a bug in current Chrome that it doesn't do something like that?

[jam, 2011/10/28 16:20:50]

I don't understand what you mean? I thought you were asking if it's ok to make
GetWebkitPrefs take one less parameter if it's redundant. I agree since the
second parameter can be figured out from the first. so can we take it out?

   WebPreferences web_prefs =
       content::GetContentClient()->browser()->GetWebkitPrefs(
-          render_view_host()->process()->browser_context(), false);
+          render_view_host(), false);
 
   // Force accelerated compositing and 2d canvas off for chrome:, about: and
   // chrome-devtools: pages (unless it's specifically allowed).
   if ((GetURL().SchemeIs(chrome::kChromeDevToolsScheme) ||
 #if !defined(TOUCH_UI)
       // Allow accelerated compositing for keyboard and log in screen.
       GetURL().SchemeIs(chrome::kChromeUIScheme) ||
 #endif
       (GetURL().SchemeIs(chrome::kAboutScheme) &&
        GetURL().spec() != chrome::kAboutBlankURL)) &&
@@ skipping 185 matching lines @@
 
 void TabContents::CreateViewAndSetSizeForRVH(RenderViewHost* rvh) {
   RenderWidgetHostView* rwh_view = view()->CreateViewForWidget(rvh);
   rwh_view->SetSize(view()->GetContainerSize());
 }
 
 bool TabContents::GotResponseToLockMouseRequest(bool allowed) {
   return render_view_host() ?
       render_view_host()->GotResponseToLockMouseRequest(allowed) : false;
 }
-