Set extension-related webkit preferences in a common location.

Set extension-related webkit preferences in a common location.

Before we were ending up with different preferences set in
different locations.

I'm not sure if this approach is right from the content-team's
point of view.

BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107882

[Aaron Boodman, 2011-10-27 05:28:49]

Zhenyao, Sorry this took so long. A lot of things came up.

John, can you comment on whether this is the right approach from content's point
of view (or assign someone else)?

[jam, 2011-10-27 17:10:23]

http://codereview.chromium.org/8403024/diff/1/content/browser/tab_contents/ta...
File content/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/8403024/diff/1/content/browser/tab_contents/ta...
content/browser/tab_contents/tab_contents.cc:1802: // web_ui, doesn't it?
you can just do
(ChildProcessSecurityPolicy::GetInstance()->HasWebUIBindings(rvh->process()->id())

[Zhenyao Mo, 2011-10-27 17:17:06]

Thanks for getting this done.  I don't really know extensions stuff enough to
review this CL so I'll stay silent with a grateful heart.

[Aaron Boodman, 2011-10-27 22:47:23]

http://codereview.chromium.org/8403024/diff/1/content/browser/tab_contents/ta...
File content/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/8403024/diff/1/content/browser/tab_contents/ta...
content/browser/tab_contents/tab_contents.cc:1802: // web_ui, doesn't it?
On 2011/10/27 17:10:24, John Abd-El-Malek wrote:
> you can just do
>
(ChildProcessSecurityPolicy::GetInstance()->HasWebUIBindings(rvh->process()->id())

Ok, but isn't it a bug in current Chrome that it doesn't do something like that?

[commit-bot: I haz the power, 2011-10-28 03:10:55]

No LGTM from valid reviewers yet.

[Aaron Boodman, 2011-10-28 07:17:29]

+mpcomplete for extensions review

John, if this is OK with you can I get an LGTM?

[jam, 2011-10-28 16:20:50]

http://codereview.chromium.org/8403024/diff/1/content/browser/tab_contents/ta...
File content/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/8403024/diff/1/content/browser/tab_contents/ta...
content/browser/tab_contents/tab_contents.cc:1802: // web_ui, doesn't it?
On 2011/10/27 22:47:23, Aaron Boodman wrote:
> On 2011/10/27 17:10:24, John Abd-El-Malek wrote:
> > you can just do
> >
>
(ChildProcessSecurityPolicy::GetInstance()->HasWebUIBindings(rvh->process()->id())
> 
> Ok, but isn't it a bug in current Chrome that it doesn't do something like
that?

I don't understand what you mean? I thought you were asking if it's ok to make
GetWebkitPrefs take one less parameter if it's redundant. I agree since the
second parameter can be figured out from the first. so can we take it out?

[Matt Perry, 2011-10-28 18:25:21]

lgtm

[Aaron Boodman, 2011-10-28 18:52:13]

John, PTAL

[jam, 2011-10-28 20:19:14]

lgtm