Issue 8403018: Fix special_tabs.SpecialTabsTest.testSpecialAcceratorTabs for chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8403018: Fix special_tabs.SpecialTabsTest.testSpecialAcceratorTabs for chromeos (Closed)

Created:
9 years, 1 month ago by Nirnimesh

Modified:
9 years, 1 month ago

Reviewers:
dennis_jeffrey

CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix special_tabs.SpecialTabsTest.testSpecialAcceratorTabs for chromeos R=dennisjeffrey@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107518

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	chrome/test/functional/special_tabs.py	View	1	3 chunks	+15 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dennis_jeffrey

9 years, 1 month ago (2011-10-27 01:25:16 UTC) #2

LGTM

http://codereview.chromium.org/8403018/diff/1/chrome/test/functional/special_...
File chrome/test/functional/special_tabs.py (right):

http://codereview.chromium.org/8403018/diff/1/chrome/test/functional/special_...
chrome/test/functional/special_tabs.py:18: """Get a dict of accels and
corresponding tab title."""
nit: "accels" --> "accelerators"
     "title" --> "titles"

Expand Messages | Collapse Messages