Fix special_tabs.SpecialTabsTest.testSpecialAcceratorTabs for chromeos

chrome/test/functional/special_tabs.py

 #!/usr/bin/python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 
 import pyauto_functional  # Must be imported before pyauto
 import pyauto
 import test_utils
 
 class SpecialTabsTest(pyauto.PyUITest):
   """TestCase for Special Tabs like about:version, chrome://history, etc."""
 
-  special_accelerator_tabs = {
-    pyauto.IDC_SHOW_HISTORY: 'History',
-    pyauto.IDC_MANAGE_EXTENSIONS: '%s - Extensions' % ('Options' if
-        pyauto.PyUITest.IsWin() else 'Preferences'),
-    pyauto.IDC_SHOW_DOWNLOADS: 'Downloads',
-  }
+  @staticmethod
+  def GetSpecialAcceleratorTabs():
+    """Get a dict of accels and corresponding tab title."""

[dennis_jeffrey, 2011/10/27 01:25:17]

nit: "accels" --> "accelerators"
     "title" --> "titles"

+    ret = {
+        pyauto.IDC_SHOW_HISTORY: 'History',
+        pyauto.IDC_MANAGE_EXTENSIONS: 'Preferences - Extensions',
+        pyauto.IDC_SHOW_DOWNLOADS: 'Downloads',
+    }
+    if pyauto.PyUITest.IsWin():
+      ret[pyauto.IDC_MANAGE_EXTENSIONS] = 'Options - Extensions'
+    elif pyauto.PyUITest.IsChromeOS():
+      ret[pyauto.IDC_MANAGE_EXTENSIONS] = 'Settings - Extensions'
+    return ret
 
   special_url_redirects = {
    'about:': 'chrome://version',
    'about:about': 'chrome://about',
    'about:appcache-internals': 'chrome://appcache-internals',
    'about:credits': 'chrome://credits',
    'about:dns': 'chrome://dns',
    'about:histograms': 'chrome://histograms',
    'about:plugins': 'chrome://plugins',
    'about:sync': 'chrome://sync-internals',
@@ skipping 69 matching lines @@
 
     # OVERRIDE - title and page different on CrOS
     'chrome://settings/about': { 'title': 'Settings - About' },
     'chrome://settings/accounts': { 'title': 'Settings - Users' },
     'chrome://settings/advanced': { 'title': 'Settings - Under the Hood' },
     'chrome://settings/autofill': { 'title': 'Settings - Autofill Settings' },
     'chrome://settings/browser': { 'title': 'Settings - Basics' },
     'chrome://settings/clearBrowserData':
       { 'title': 'Settings - Clear Browsing Data' },
     'chrome://settings/content': { 'title': 'Settings - Content Settings' },
+    'chrome://settings/extensions': { 'title': 'Settings - Extensions' },
     'chrome://settings/internet': { 'title': 'Settings - Internet' },
     'chrome://settings/languages':
       { 'title': 'Settings - Languages and Input' },
     'chrome://settings/passwords': { 'title': 'Settings - Passwords' },
     'chrome://settings/personal': { 'title': 'Settings - Personal Stuff' },
     'chrome://settings/proxy': { 'title': 'Proxy' },
     'chrome://settings/system': { 'title': 'Settings - System' },
   }
   broken_chromeos_special_url_tabs = {
     # returns "not available" page on chromeos=1 linux but has an URL constant.
@@ skipping 195 matching lines @@
 
   def testAboutDNSTab(self):
     """Test DNS tab to confirm DNS about page propogates records."""
     self.NavigateToURL('about:dns')
     self._VerifyAboutDNS()
     self.assertEqual('About DNS', self.GetActiveTabTitle())
 
   def testSpecialAcceratorTabs(self):
     """Test special tabs created by acclerators like IDC_SHOW_HISTORY,
        IDC_SHOW_DOWNLOADS."""
-    for accel, title in self.special_accelerator_tabs.iteritems():
+    for accel, title in self.GetSpecialAcceleratorTabs().iteritems():
       self.RunCommand(accel)
       self.assertTrue(self.WaitUntil(
             self.GetActiveTabTitle, expect_retval=title),
           msg='Expected "%s"' % title)
 
 
 if __name__ == '__main__':
   pyauto_functional.Main()