chrome/browser/sync/engine/apply_updates_command_unittest.cc - Issue 8402014: [Sync] Make GetFirstChildId return a flag indicating success

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/apply_updates_command_unittest.cc

Issue 8402014: [Sync] Make GetFirstChildId return a flag indicating success (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cleanup comments Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/engine/apply_updates_command_unittest.cc

diff --git a/chrome/browser/sync/engine/apply_updates_command_unittest.cc b/chrome/browser/sync/engine/apply_updates_command_unittest.cc

index 7ea70c371bc1b4431b5c6e35e634990f240c37bb..852379137544a54142a6c7fe76cfdbf3c1968309 100644

--- a/chrome/browser/sync/engine/apply_updates_command_unittest.cc

+++ b/chrome/browser/sync/engine/apply_updates_command_unittest.cc

@@ -113,7 +113,9 @@ class ApplyUpdatesCommandTest : public SyncerCommandTest {

ScopedDirLookup dir(syncdb()->manager(), syncdb()->name());

ASSERT_TRUE(dir.good());

WriteTransaction trans(FROM_HERE, UNITTEST, dir);

- Id predecessor_id = dir->GetLastChildId(&trans, parent_id);

+ Id predecessor_id;

+ ASSERT_TRUE(

+ dir->GetLastChildIdForTest(&trans, parent_id, &predecessor_id));

MutableEntry entry(&trans, syncable::CREATE, parent_id, name);

ASSERT_TRUE(entry.good());

entry.Put(syncable::ID, item_id);