[Sync] Make GetFirstChildId return a flag indicating success

chrome/browser/sync/internal_api/change_reorder_buffer.h

Index: chrome/browser/sync/internal_api/change_reorder_buffer.h
diff --git a/chrome/browser/sync/internal_api/change_reorder_buffer.h b/chrome/browser/sync/internal_api/change_reorder_buffer.h
index c78bcaca8dc7ac5fc21c44c1bd753de364f8b7e9..ac7d90f6573eb925defa53fc026315ddb506fbd9 100644
--- a/chrome/browser/sync/internal_api/change_reorder_buffer.h
+++ b/chrome/browser/sync/internal_api/change_reorder_buffer.h
@@ -84,11 +84,12 @@ class ChangeReorderBuffer {
     return operations_.empty();
   }
 
-  // Output a reordered list of changes to |changelist| using the items that
-  // were pushed into the reorder buffer. |sync_trans| is used to determine the
-  // ordering.
-  ImmutableChangeRecordList
-      GetAllChangesInTreeOrder(const BaseTransaction* sync_trans);
+  // Output a reordered list of changes to |changes| using the items
+  // that were pushed into the reorder buffer. |sync_trans| is used to
+  // determine the ordering.  Returns true if successful, or false if
+  // an error was encountered.
+  bool GetAllChangesInTreeOrder(const BaseTransaction* sync_trans,
+                                ImmutableChangeRecordList* changes);

[Nicolas Zea, 2011/10/27 18:28:30]

consider WARN_UNUSED_RESULT

[akalin, 2011/10/27 21:11:43]

Done.

 
  private:
   class Traversal;