Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 8401019: [webkit glue] Make signedPublicKeyAndChallengeString() return an empty instead of null string. (Closed)

Created:
9 years, 1 month ago by gauravsh
Modified:
9 years, 1 month ago
Reviewers:
tony, jamesr
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[webkit glue] Make signedPublicKeyAndChallengeString() return an empty instead of null string. This is needed for the <keygen> regression test to work The webkit bug (and associated discussion) is here: https://bugs.webkit.org/show_bug.cgi?id=70617 BUG=chromium-os:21905 TEST=regression test now works without additional changes to appendForm() Change-Id: I0fffb6a885a75ac7a0acecce06034d8cdeab6832 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M webkit/glue/webkitplatformsupport_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gauravsh
9 years, 1 month ago (2011-10-27 16:42:35 UTC) #1
jamesr
lgtm
9 years, 1 month ago (2011-10-28 21:09:11 UTC) #2
tony
LGTM
9 years, 1 month ago (2011-10-28 21:16:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/8401019/1
9 years, 1 month ago (2011-10-30 17:37:32 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-10-30 23:31:28 UTC) #5
Change committed as 107906

Powered by Google App Engine
This is Rietveld 408576698