Chrome: enable move cursor by word in visual order for windows by command line flag

To minimize the risk to LTR users, we are thinking to enable this feature first to chromium win by command line flag. (This and corresponding changset in webkit should be removed after this feature is enabled without command line flag).

This is chromium side's change that
1. adds command-line flag: --enable-visual-word-movement
2. passes this per-page setting to WebCore::Settings through WebPreferences.

The dependent WebKit change is in
http://trac.webkit.org/changeset/99255

workflow:
1. adds command line flag --enable-visual-word-movement, pass it to WebCore::Settings through WebPreferences.
2. (WebKit) in FrameSelection::modifyMovingLeft|Right, when 'visualWordMovementEnabled' is true in page's Settings, trigger visual word movement instead of logical one.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109133

[jam, 2011-11-04 16:09:57]

lgtm

please don't add 4 reviewers in the future

[xji, 2011-11-04 17:49:45]

On 2011/11/04 16:09:57, John Abd-El-Malek wrote:
> lgtm
> 
> please don't add 4 reviewers in the future
:) I thought I have to get 'lgtm' from each directory owner. each reviewer is
the owner from different directories. only darin@ might not be added since you
or brettw share the same owner directory with him, I added him because he
informally reviewed the webkit's chromium api part.

[tony, 2011-11-04 19:14:53]

webkit/{glue,tools} LGTM.

I would get rid of the #if defined(OS_WIN).  I mean, it's behind a command line
flag, so why does it also need to be limited to Win?

[xji, 2011-11-04 19:19:35]

On 2011/11/04 19:14:53, tony wrote:
> webkit/{glue,tools} LGTM.
> 
> I would get rid of the #if defined(OS_WIN).  I mean, it's behind a command
line
> flag, so why does it also need to be limited to Win?

Different platform handles word break differently.
for Win, "abc def hij", word breaks are "|abc |def |hij", no matter you press
ctrl-left-arrow or ctrl-right-arrow.
for mac/linux, the word breaks are "abc| def| hij|" when press ctrl-right-arrow.
they are "|abc |def |hij" when press ctrl-left-arrow.

the current implementation matches the native behavior of win.

[Avi (use Gerrit), 2011-11-08 18:36:04]

owner rubberstamp lgtm

[tony, 2011-11-08 18:39:20]

On 2011/11/04 19:19:35, xji wrote:
> On 2011/11/04 19:14:53, tony wrote:
> > webkit/{glue,tools} LGTM.
> > 
> > I would get rid of the #if defined(OS_WIN).  I mean, it's behind a command
> line
> > flag, so why does it also need to be limited to Win?
> 
> Different platform handles word break differently.
> for Win, "abc def hij", word breaks are "|abc |def |hij", no matter you press
> ctrl-left-arrow or ctrl-right-arrow.
> for mac/linux, the word breaks are "abc| def| hij|" when press
ctrl-right-arrow.
> they are "|abc |def |hij" when press ctrl-left-arrow.
> 
> the current implementation matches the native behavior of win.

FWIW, I would still get rid of the #if and just file a bug for the linux/mac
behavior.  It'll be a bit weird on linux/mac, but it's OK for features behind a
command line flag to have bugs.

[commit-bot: I haz the power, 2011-11-08 22:41:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xji@chromium.org/8400078/16007

[commit-bot: I haz the power, 2011-11-09 00:00:31]

Change committed as 109133