Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 8400073: Revert 107793 - Fully enable about:tracking by default (Closed)

Created:
9 years, 1 month ago by jar (doing other things)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Paweł Hajdan Jr., sadrul, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 107793 - Fully enable about:tracking by default Support is now controlled by the flag: --enable-tracking and the default is always on. To turn it off, use: --enable-tracking=0 All profiler code is compiled now in release and official builds (in addition to debug, where it was already active), but most entry points can be disabled (turned into no-ops) by a single const bool setting atop tracked_objects.cc (in case folks want to revert the perf-impact of this change). Transition to faster Now() service on Windows for the profiler use only. The TimeTicks::Now() function on Window uses locking to get a 64 bit time value. This CL transitions times used for profiling to more directly use a 32 bit Time interface, which is actually what drives the 64 bit TimeTicks. By using the smaller value, we avoid the need for locks, or even atomic operations for the most part in the tracking system. On linux, we just down-sample the standard TimeTicks to 32 bits for consistency (clean ability to snapshot asyncronously without atomics... but I should verify that such is helpful to performance). I've also put in yet more cleanup and refactoring. r=rtenneti bug=101856 Review URL: http://codereview.chromium.org/8391019 TBR=jar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -576 lines) Patch
M base/location.h View 1 chunk +6 lines, -0 lines 0 comments Download
M base/message_loop.h View 4 chunks +14 lines, -17 lines 0 comments Download
M base/message_loop.cc View 2 chunks +15 lines, -20 lines 0 comments Download
M base/threading/thread.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/threading/worker_pool_posix.h View 1 chunk +4 lines, -2 lines 0 comments Download
M base/threading/worker_pool_posix.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M base/threading/worker_pool_win.cc View 2 chunks +15 lines, -9 lines 0 comments Download
M base/tracked_objects.h View 21 chunks +66 lines, -186 lines 0 comments Download
M base/tracked_objects.cc View 18 chunks +128 lines, -173 lines 0 comments Download
M base/tracked_objects_unittest.cc View 12 chunks +96 lines, -141 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 5 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 3 chunks +1 line, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 3 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jar (doing other things)
9 years, 1 month ago (2011-10-28 21:41:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698