Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 8391019: Fully enable about:tracking by default (Closed)

Created:
9 years, 1 month ago by jar (doing other things)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Paweł Hajdan Jr., sadrul, brettw-cc_chromium.org, eroman
Visibility:
Public.

Description

Fully enable about:tracking by default Support is now controlled by the flag: --enable-tracking and the default is always on. To turn it off, use: --enable-tracking=0 All profiler code is compiled now in release and official builds (in addition to debug, where it was already active), but most entry points can be disabled (turned into no-ops) by a single const bool setting atop tracked_objects.cc (in case folks want to revert the perf-impact of this change). Transition to faster Now() service on Windows for the profiler use only. The TimeTicks::Now() function on Window uses locking to get a 64 bit time value. This CL transitions times used for profiling to more directly use a 32 bit Time interface, which is actually what drives the 64 bit TimeTicks. By using the smaller value, we avoid the need for locks, or even atomic operations for the most part in the tracking system. On linux, we just down-sample the standard TimeTicks to 32 bits for consistency (clean ability to snapshot asyncronously without atomics... but I should verify that such is helpful to performance). I've also put in yet more cleanup and refactoring. r=rtenneti bug=101856 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107793

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 4

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+576 lines, -379 lines) Patch
M base/location.h View 1 2 3 4 5 6 1 chunk +0 lines, -6 lines 0 comments Download
M base/message_loop.h View 1 2 3 4 5 6 4 chunks +17 lines, -14 lines 0 comments Download
M base/message_loop.cc View 1 2 3 4 5 6 7 2 chunks +20 lines, -15 lines 0 comments Download
M base/threading/thread.cc View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M base/threading/worker_pool_posix.h View 1 2 3 4 5 6 1 chunk +2 lines, -4 lines 0 comments Download
M base/threading/worker_pool_posix.cc View 1 2 3 4 5 6 2 chunks +8 lines, -11 lines 0 comments Download
M base/threading/worker_pool_win.cc View 1 2 3 4 5 6 2 chunks +9 lines, -15 lines 0 comments Download
M base/tracked_objects.h View 1 2 3 4 5 6 21 chunks +186 lines, -66 lines 0 comments Download
M base/tracked_objects.cc View 1 2 3 4 5 6 18 chunks +173 lines, -128 lines 0 comments Download
M base/tracked_objects_unittest.cc View 1 2 3 4 5 6 12 chunks +141 lines, -96 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 3 4 5 6 7 8 9 5 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/chrome_browser_main.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 3 chunks +2 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 7 8 3 chunks +16 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jar (doing other things)
Darin: Please look at changes to message_loop.* Specifically, my factoring of PendingTask into a public ...
9 years, 1 month ago (2011-10-28 02:02:40 UTC) #1
ramant (doing other things)
lgtm http://codereview.chromium.org/8391019/diff/4004/base/tracked_objects.cc File base/tracked_objects.cc (right): http://codereview.chromium.org/8391019/diff/4004/base/tracked_objects.cc#newcode165 base/tracked_objects.cc:165: Initialize(); // Always initialize if needed. nit: if ...
9 years, 1 month ago (2011-10-28 17:56:09 UTC) #2
jar (doing other things)
9 years, 1 month ago (2011-10-28 19:37:25 UTC) #3
Changes made per comments by rtenneti

http://codereview.chromium.org/8391019/diff/4004/base/tracked_objects.cc
File base/tracked_objects.cc (right):

http://codereview.chromium.org/8391019/diff/4004/base/tracked_objects.cc#newc...
base/tracked_objects.cc:165: Initialize();  // Always initialize if needed.
On 2011/10/28 17:56:09, ramant wrote:
> nit: if not initialized bail.

Done.

http://codereview.chromium.org/8391019/diff/4004/base/tracked_objects.cc#newc...
base/tracked_objects.cc:486: if (status_ != UNINITIALIZED)
On 2011/10/28 17:56:09, ramant wrote:
> nit: return false if not enabled.

Done.

Powered by Google App Engine
This is Rietveld 408576698