Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Issue 8399032: Handlify CompileConstructStub. (Closed)

Created:
9 years, 1 month ago by ulan
Modified:
9 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Handlify CompileConstructStub. Based on 8391045. R=kmillikin@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9837

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -90 lines) Patch
M src/arm/stub-cache-arm.cc View 4 chunks +10 lines, -13 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 4 chunks +7 lines, -11 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime.cc View 1 chunk +3 lines, -6 lines 3 comments Download
M src/stub-cache.h View 2 chunks +2 lines, -9 lines 0 comments Download
M src/stub-cache.cc View 2 chunks +5 lines, -37 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 4 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
Please take a look. http://codereview.chromium.org/8399032/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/8399032/diff/1/src/runtime.cc#newcode8181 src/runtime.cc:8181: static void TrySettingInlineConstructStub(Isolate* isolate, The ...
9 years, 1 month ago (2011-10-27 11:37:37 UTC) #1
Kevin Millikin (Chromium)
9 years, 1 month ago (2011-10-27 12:35:24 UTC) #2
LGTM with one small change noted.

http://codereview.chromium.org/8399032/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/8399032/diff/1/src/runtime.cc#newcode8181
src/runtime.cc:8181: static void TrySettingInlineConstructStub(Isolate* isolate,
On 2011/10/27 11:37:37, ulan wrote:
> The "Try" in the name bothers me, but I cannot remove it because the stub is
set
> or not set depending on CanGenerateInlineConstructor.

That's OK, it's a different kind of "Try".  There is no allocation failure.

http://codereview.chromium.org/8399032/diff/1/src/runtime.cc#newcode8191
src/runtime.cc:8191: Code::cast(code->ToObjectUnchecked()));
...->set_construct_stub(*code);

Powered by Google App Engine
This is Rietveld 408576698