Handlify CompileConstructStub.

src/runtime.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 8160 matching lines @@
       Execution::New(Handle<JSFunction>::cast(bound_function),
                      total_argc, *param_data, &exception);
   if (exception) {
     return Failure::Exception();
   }
   ASSERT(!result.is_null());
   return *result;
 }
 
 
 static void TrySettingInlineConstructStub(Isolate* isolate,

[ulan, 2011/10/27 11:37:37]

The "Try" in the name bothers me, but I cannot remove it because the stub is set
or not set depending on CanGenerateInlineConstructor.

[Kevin Millikin (Chromium), 2011/10/27 12:35:24]

That's OK, it's a different kind of "Try".  There is no allocation failure.

                                           Handle<JSFunction> function) {
   Handle<Object> prototype = isolate->factory()->null_value();
   if (function->has_instance_prototype()) {
     prototype = Handle<Object>(function->instance_prototype(), isolate);
   }
   if (function->shared()->CanGenerateInlineConstructor(*prototype)) {
-    HandleScope scope(isolate);
     ConstructStubCompiler compiler(isolate);
-    MaybeObject* code = compiler.CompileConstructStub(*function);
-    if (!code->IsFailure()) {
-      function->shared()->set_construct_stub(
-          Code::cast(code->ToObjectUnchecked()));
-    }
+    Handle<Code> code = compiler.CompileConstructStub(function);
+    function->shared()->set_construct_stub(
+        Code::cast(code->ToObjectUnchecked()));

[Kevin Millikin (Chromium), 2011/10/27 12:35:24]

...->set_construct_stub(*code);

   }
 }
 
 
 RUNTIME_FUNCTION(MaybeObject*, Runtime_NewObject) {
   HandleScope scope(isolate);
   ASSERT(args.length() == 1);
 
   Handle<Object> constructor = args.at<Object>(0);
 
@@ skipping 5321 matching lines @@
   } else {
     // Handle last resort GC and make sure to allow future allocations
     // to grow the heap without causing GCs (if possible).
     isolate->counters()->gc_last_resort_from_js()->Increment();
     isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
   }
 }
 
 
 } }  // namespace v8::internal