[cros] Don't succeed if user has default profile picturewq

chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
@@ skipping 286 matching lines @@
                                      UserManager::User::kExternalImageIndex);
   user_manager->SaveUserImage(
       user.email(), photo, UserManager::User::kExternalImageIndex);
   UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
                             kHistogramImageFromCamera,
                             kHistogramImagesCount);
 }
 
 void ChangePictureOptionsHandler::OnDownloadSuccess(const SkBitmap& image) {
   // Profile image has been downloaded.
-  // TODO(ivankr): check if profile image is default image.
+  VLOG(1) << "Download of profile image on change picture failed.";
+  UMA_HISTOGRAM_ENUMERATION("UserImageDownloadResult.ChangePicture",
+                            ProfileImageDownloader::kDownloadSuccess,
+                            ProfileImageDownloader::kDownloadResultsCount);
 
   std::string profile_image_data_url = web_ui_util::GetImageDataUrl(image);
   if (profile_image_data_url != profile_image_data_url_) {
+    VLOG(1) << "Updating profile image for the user";

[Ivan Korotkov, 2011/10/27 13:58:15]

As discussed offline, this will report a change everytime a profile image is
download and profile_image_data_url_ is kAboutUrl.

+    UMA_HISTOGRAM_ENUMERATION("UserImageDownloadResult.ChangePicture",
+                              ProfileImageDownloader::kDownloadSuccessChanged,
+                              ProfileImageDownloader::kDownloadResultsCount);
+
     // Differs from the current profile image.
     profile_image_ = image;
     profile_image_data_url_ = profile_image_data_url;
 
     base::StringValue image_data_url(profile_image_data_url);
     base::FundamentalValue select(false);
     web_ui_->CallJavascriptFunction("ChangePictureOptions.setProfileImage",
                                     image_data_url, select);
   }
 }
 
+void ChangePictureOptionsHandler::OnDownloadFailure() {
+  VLOG(1) << "Download of profile image on change picture failed.";
+  UMA_HISTOGRAM_ENUMERATION("UserImageDownloadResult.ChangePicture",
+                            ProfileImageDownloader::kDownloadFailure,
+                            ProfileImageDownloader::kDownloadResultsCount);
+}
+
+void ChangePictureOptionsHandler::OnDownloadDefaultImage() {
+  VLOG(1) << "User still has the default profile image.";
+  UMA_HISTOGRAM_ENUMERATION("UserImageDownloadResult.ChangePicture",
+                            ProfileImageDownloader::kDownloadDefault,
+                            ProfileImageDownloader::kDownloadResultsCount);
+}
+
 void ChangePictureOptionsHandler::CheckCameraPresence() {
   CameraDetector::StartPresenceCheck(
       base::Bind(&ChangePictureOptionsHandler::OnCameraPresenceCheckDone,
                  weak_factory_.GetWeakPtr()));
 }
 
 void ChangePictureOptionsHandler::SetCameraPresent(bool present) {
   base::FundamentalValue present_value(present);
   web_ui_->CallJavascriptFunction("ChangePictureOptions.setCameraPresent",
                                   present_value);
@@ skipping 27 matching lines @@
 
 gfx::NativeWindow ChangePictureOptionsHandler::GetBrowserWindow() const {
   Browser* browser =
       BrowserList::FindBrowserWithProfile(Profile::FromWebUI(web_ui_));
   if (!browser)
     return NULL;
   return browser->window()->GetNativeHandle();
 }
 
 }  // namespace chromeos