Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/CompilerListener.java

Issue 8395013: DartC User Warning Framework (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use new ErrorCode enums in single onError() method. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/CompilerListener.java
diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/CompilerListener.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/CompilerListener.java
index b6d30e4d84d187420cab9d6e1c295171c4cea6e0..0dd3e0fc62a68ba80ed37ee07486cf318a90c8ce 100644
--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/CompilerListener.java
+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/CompilerListener.java
@@ -16,6 +16,8 @@ package com.google.dart.tools.core.internal.builder;
import com.google.dart.compiler.DartCompilationError;
import com.google.dart.compiler.DartCompilerContext;
import com.google.dart.compiler.DartCompilerListener;
+import com.google.dart.compiler.ErrorSeverity;
+import com.google.dart.compiler.SubSystem;
import com.google.dart.compiler.ast.DartUnit;
import com.google.dart.tools.core.DartCore;
import com.google.dart.tools.core.internal.util.ResourceUtil;
@@ -56,18 +58,14 @@ class CompilerListener extends DartCompilerListener {
}
@Override
- public void compilationError(DartCompilationError error) {
- processError(error);
- }
-
- @Override
- public void compilationWarning(DartCompilationError error) {
- processWarning(error);
- }
-
- @Override
- public void typeError(DartCompilationError error) {
- processWarning(error);
+ public void onError(DartCompilationError event) {
+ if (event.getErrorCode().getSubSystem() == SubSystem.STATIC_TYPE) {
+ processWarning(event);
+ } else if (event.getErrorCode().getErrorSeverity() == ErrorSeverity.ERROR) {
+ processError(event);
+ } else if (event.getErrorCode().getErrorSeverity() == ErrorSeverity.WARNING) {
+ processWarning(event);
+ }
}
/**

Powered by Google App Engine
This is Rietveld 408576698