Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: compiler/java/com/google/dart/runner/DartRunner.java

Issue 8395013: DartC User Warning Framework (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use new ErrorCode enums in single onError() method. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/runner/DartRunner.java
diff --git a/compiler/java/com/google/dart/runner/DartRunner.java b/compiler/java/com/google/dart/runner/DartRunner.java
index cabe6214126772afdd09707f1e2c720d71106dbd..87c12a1582712c505b08ddeaad5a76de02d0abf0 100644
--- a/compiler/java/com/google/dart/runner/DartRunner.java
+++ b/compiler/java/com/google/dart/runner/DartRunner.java
@@ -13,7 +13,6 @@ import com.google.dart.compiler.CommandLineOptions;
import com.google.dart.compiler.CommandLineOptions.DartRunnerOptions;
import com.google.dart.compiler.CompilerConfiguration;
import com.google.dart.compiler.DartArtifactProvider;
-import com.google.dart.compiler.DartCompilationError;
import com.google.dart.compiler.DartCompiler;
import com.google.dart.compiler.DartCompilerListener;
import com.google.dart.compiler.DefaultCompilerConfiguration;
@@ -75,7 +74,6 @@ public class DartRunner {
public static void main(String[] args) {
try {
boolean runBatch = false;
- final List<LibrarySource> imports = Collections.emptyList();
DartRunnerOptions options = processCommandLineOptions(args);
if (options.shouldBatch()) {
runBatch = true;
@@ -130,16 +128,12 @@ public class DartRunner {
{
((DefaultErrorFormatter) formatter).setOutputStream(stderr);
zundel 2011/10/27 16:19:54 this is pretty ugly, could you make an overload co
}
- @Override
- public void compilationWarning(DartCompilationError event) {
- compilationError(event);
- }
};
CompilationResult compiled;
compiled = compileApp(app, imports, options, listener);
- if (listener.getProblemCount() != 0) {
+ if (listener.getErrorCount() != 0) {
throw new RunnerError("Compilation failed.");
}

Powered by Google App Engine
This is Rietveld 408576698