DartC User Warning Framework

compiler/java/com/google/dart/runner/DartRunner.java

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 package com.google.dart.runner;
 
 import com.google.common.base.Joiner;
 import com.google.common.collect.Lists;
 import com.google.common.io.CharStreams;
 import com.google.common.io.Files;
 import com.google.dart.compiler.Backend;
 import com.google.dart.compiler.CommandLineOptions;
 import com.google.dart.compiler.CommandLineOptions.DartRunnerOptions;
 import com.google.dart.compiler.CompilerConfiguration;
 import com.google.dart.compiler.DartArtifactProvider;
-import com.google.dart.compiler.DartCompilationError;
 import com.google.dart.compiler.DartCompiler;
 import com.google.dart.compiler.DartCompilerListener;
 import com.google.dart.compiler.DefaultCompilerConfiguration;
 import com.google.dart.compiler.DefaultDartCompilerListener;
 import com.google.dart.compiler.DefaultErrorFormatter;
 import com.google.dart.compiler.LibrarySource;
 import com.google.dart.compiler.Source;
 import com.google.dart.compiler.UnitTestBatchRunner;
 import com.google.dart.compiler.UnitTestBatchRunner.Invocation;
 import com.google.dart.compiler.UrlLibrarySource;
@@ skipping 41 matching lines @@
       System.exit(1);
     }
 
     assert parsedOptions != null;
     return parsedOptions;
   }
 
   public static void main(String[] args) {
     try {
       boolean runBatch = false;
-      final List<LibrarySource> imports = Collections.emptyList();
       DartRunnerOptions options = processCommandLineOptions(args);
       if (options.shouldBatch()) {
         runBatch = true;
         if (args.length > 1) {
           System.err
               .println("(Extra arguments specified with -batch ignored.)");
         }
       }
       if (runBatch) {
         UnitTestBatchRunner.runAsBatch(args, new Invocation() {
@@ skipping 32 matching lines @@
 
     String script = options.getSourceFiles().get(0);
     ArrayList<String> scriptArguments = new ArrayList<String>();
 
     LibrarySource app = new UrlLibrarySource(new File(script));
 
     File outFile =  options.getOutputFilename();
 
     DefaultDartCompilerListener listener = new DefaultDartCompilerListener() {
         {
           ((DefaultErrorFormatter) formatter).setOutputStream(stderr);

[zundel, 2011/10/27 16:19:54]

this is pretty ugly, could you make an overload constructor to set the output
stream instead?

         }
-        @Override
-        public void compilationWarning(DartCompilationError event) {
-          compilationError(event);
-        }
       };
 
     CompilationResult compiled;
     compiled = compileApp(app, imports, options, listener);
 
-    if (listener.getProblemCount() != 0) {
+    if (listener.getErrorCount() != 0) {
       throw new RunnerError("Compilation failed.");
     }
 
     if (outFile != null) {
       File dir = outFile.getParentFile();
       if (dir != null) {
         if (!dir.exists()) {
           throw new RunnerError("Cannot create: " + outFile.getName()
                                 + ".  " + dir + " does not exist");
         }
@@ skipping 197 matching lines @@
       Reader r = provider.getArtifactReader(app, "", backend.getAppExtension());
       String js = CharStreams.toString(r);
       r.close();
       return new CompilationResult(js, mapping);
     } catch (IOException e) {
       // This can't happen; it's just a StringWriter.
       throw new AssertionError(e);
     }
   }
 }