compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java - Issue 8395013: DartC User Warning Framework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

Issue 8395013: DartC User Warning Framework (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use new ErrorCode enums in single onError() method. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java ('k') | compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java » ('j') | compiler/java/com/google/dart/runner/DartRunner.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java b/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

index d9e3dee109b3aeb22868ef8d395b132cdde3fa98..526131c0b657aa6ee21a7440223beac3cc3f8803 100644

--- a/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

+++ b/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

@@ -7,7 +7,6 @@ package com.google.dart.compiler.resolver;

import com.google.common.annotations.VisibleForTesting;

import com.google.dart.compiler.DartCompilationError;

import com.google.dart.compiler.DartCompilerContext;

-import com.google.dart.compiler.DartCompilerErrorCode;

import com.google.dart.compiler.DartCompilerListener;

import com.google.dart.compiler.ErrorCode;

import com.google.dart.compiler.ast.DartClass;

@@ -92,7 +91,7 @@ public class TopLevelElementBuilder {

void compilationError(DartCompilerListener listener, SourceInfo node, ErrorCode errorCode,

Object... args) {

DartCompilationError error = new DartCompilationError(node, errorCode, args);

- listener.compilationError(error);

+ listener.onError(error);

}

private void declare(Element element, DartCompilerListener listener, Scope scope) {

@@ -100,10 +99,10 @@ public class TopLevelElementBuilder {

if (originalElement != null) {

DartNode originalNode = originalElement.getNode();

if (originalNode != null) {

- compilationError(listener, originalNode, DartCompilerErrorCode.DUPLICATE_DEFINITION,

+ compilationError(listener, originalNode, ResolverErrorCode.DUPLICATE_DEFINITION,

originalElement.getName());

}

- compilationError(listener, element.getNode(), DartCompilerErrorCode.DUPLICATE_DEFINITION,

+ compilationError(listener, element.getNode(), ResolverErrorCode.DUPLICATE_DEFINITION,

originalElement.getName());

}