compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java - Issue 8395013: DartC User Warning Framework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java

Issue 8395013: DartC User Warning Framework (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use new ErrorCode enums in single onError() method. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/CompileTimeConstVisitor.java ('k') | compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java » ('j') | compiler/java/com/google/dart/runner/DartRunner.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java b/compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java

index b14a6819fa66eee466b0776c849437e93eeb2608..edfb46a1577ec3cf61ad3cd56d69449ce67d09a0 100644

--- a/compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java

+++ b/compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java

@@ -5,7 +5,6 @@

package com.google.dart.compiler.resolver;

import com.google.dart.compiler.DartCompilationError;

-import com.google.dart.compiler.DartCompilerErrorCode;

import com.google.dart.compiler.DartCompilerListener;

import com.google.dart.compiler.parser.DartScanner.Location;

import com.google.dart.compiler.type.DynamicType;

@@ -60,11 +59,10 @@ public class CoreTypeProviderImplementation implements CoreTypeProvider {

private static InterfaceType getType(String name, Scope scope, DartCompilerListener listener) {

ClassElement element = (ClassElement) scope.findElement(scope.getLibrary(), name);

if (element == null) {

- Location location = null;

DartCompilationError error =

new DartCompilationError(null, Location.NONE,

- DartCompilerErrorCode.CANNOT_BE_RESOLVED, name);

- listener.compilationError(error);

+ ResolverErrorCode.CANNOT_BE_RESOLVED, name);

+ listener.onError(error);

return Types.newDynamicType();

}

return element.getType();