compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java - Issue 8395013: DartC User Warning Framework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java

Issue 8395013: DartC User Warning Framework (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use new ErrorCode enums in single onError() method. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/backend/js/ClosureJsErrorCode.java ('k') | compiler/java/com/google/dart/compiler/backend/js/JsErrorCode.java » ('j') | compiler/java/com/google/dart/runner/DartRunner.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java

diff --git a/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java b/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java

index cd6b9fb14721d2678eedbe6744fc9b9ed4f139e0..43f0a9f04cb2e44288423189e3946fdb60c27716 100644

--- a/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java

+++ b/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java

@@ -7,7 +7,6 @@ package com.google.dart.compiler.backend.js;

import com.google.common.collect.Lists;

import com.google.dart.compiler.DartCompilationError;

import com.google.dart.compiler.DartCompilerContext;

-import com.google.dart.compiler.DartCompilerErrorCode;

import com.google.dart.compiler.InternalCompilerException;

import com.google.dart.compiler.ast.DartArrayAccess;

import com.google.dart.compiler.ast.DartArrayLiteral;

@@ -3407,7 +3406,7 @@ public class GenerateJavascriptAST {

}

private void reportError(DartNode node, Throwable exception) {

- context.compilationError(new DartCompilationError(node, DartCompilerErrorCode.INTERNAL_ERROR,

+ context.onError(new DartCompilationError(node, JsErrorCode.INTERNAL_ERROR,

exception.getLocalizedMessage()));

}