compiler/java/com/google/dart/compiler/backend/js/ClosureJsBackend.java - Issue 8395013: DartC User Warning Framework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/backend/js/ClosureJsBackend.java

Issue 8395013: DartC User Warning Framework (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use new ErrorCode enums in single onError() method. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java ('k') | compiler/java/com/google/dart/compiler/backend/js/ClosureJsErrorCode.java » ('j') | compiler/java/com/google/dart/runner/DartRunner.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/backend/js/ClosureJsBackend.java

diff --git a/compiler/java/com/google/dart/compiler/backend/js/ClosureJsBackend.java b/compiler/java/com/google/dart/compiler/backend/js/ClosureJsBackend.java

index 091c3dee7bd624bf4db2afb511d55a49983afb4c..c6b046b6de4bacf4f5e302d8c82e309eb92bbd61 100644

--- a/compiler/java/com/google/dart/compiler/backend/js/ClosureJsBackend.java

+++ b/compiler/java/com/google/dart/compiler/backend/js/ClosureJsBackend.java

@@ -348,10 +348,11 @@ public class ClosureJsBackend extends AbstractJsBackend {

source = new MockSource(error.sourceName);

}

System.err.println("error optimizing:" + error.toString());

- @SuppressWarnings("deprecation")

- DartCompilationError event = new DartCompilationError(

- new JSErrorSourceInfo(error, source), error.description);

- context.compilationError(event);

+ DartCompilationError dartError =

+ new DartCompilationError(new JSErrorSourceInfo(error, source),

+ ClosureJsErrorCode.INTERNAL_ERROR,

+ error.description);

+ context.onError(dartError);

}