Issue 8395010: fix for opening a file that does not belong to a library

Issue 8395010: fix for opening a file that does not belong to a library (Closed)

Created:
9 years, 2 months ago by keertip

Modified:
9 years, 2 months ago

Reviewers:
messick, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

fix for opening a file that does not belong to a library Committed: https://code.google.com/p/dart/source/detail?r=705

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -13 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/handlers/HandlerMessages.java	View		2 chunks	+10 lines, -10 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/handlers/HandlerMessages.properties	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/handlers/OpenFileHandler.java	View		4 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM http://codereview.chromium.org/8395010/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/handlers/HandlerMessages.properties File editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/handlers/HandlerMessages.properties (right): http://codereview.chromium.org/8395010/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/handlers/HandlerMessages.properties#newcode9 editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/handlers/HandlerMessages.properties:9: OpenFile_errorFileNotInLibrary= Cannot open {0} as it is not ...

9 years, 2 months ago (2011-10-25 18:12:18 UTC) #3

keertip

9 years, 2 months ago (2011-10-25 18:18:30 UTC) #4

http://codereview.chromium.org/8395010/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/handlers/HandlerMessages.properties
(right):

http://codereview.chromium.org/8395010/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/handlers/HandlerMessages.properties:9:
OpenFile_errorFileNotInLibrary= Cannot open {0} as it is not part of a library.
Try creating a library and adding {0} to library.
On 2011/10/25 18:12:18, Brian Wilkerson wrote:
> "to library" --> "to the library" or "to it"

Done.

Expand Messages | Collapse Messages