Issue 8393036: base::Bind: Convert BrowsingDataLocalStorageHelper::StartFetching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8393036: base::Bind: Convert BrowsingDataLocalStorageHelper::StartFetching. (Closed)

Created:
9 years, 1 month ago by James Hawkins

Modified:
9 years, 1 month ago

Reviewers:
csilv

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base::Bind: Convert BrowsingDataLocalStorageHelper::StartFetching. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107522

Patch Set 3 : Review fix. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -41 lines)			Patch
M	chrome/browser/browsing_data_local_storage_helper.h	View	1	5 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome/browser/browsing_data_local_storage_helper.cc	View		5 chunks	+12 lines, -11 lines	0 comments	Download
M	chrome/browser/browsing_data_local_storage_helper_browsertest.cc	View	1 2	5 chunks	+9 lines, -4 lines	0 comments	Download
M	chrome/browser/cookies_tree_model.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_local_storage_helper.h	View		4 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_local_storage_helper.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

lgtm http://codereview.chromium.org/8393036/diff/1/chrome/browser/browsing_data_local_storage_helper_browsertest.cc File chrome/browser/browsing_data_local_storage_helper_browsertest.cc (right): http://codereview.chromium.org/8393036/diff/1/chrome/browser/browsing_data_local_storage_helper_browsertest.cc#newcode8 chrome/browser/browsing_data_local_storage_helper_browsertest.cc:8: #include "base/bind.h" add bind_helpers.h

9 years, 1 month ago (2011-10-26 17:40:56 UTC) #2

James Hawkins

9 years, 1 month ago (2011-10-26 22:59:40 UTC) #3

http://codereview.chromium.org/8393036/diff/1/chrome/browser/browsing_data_lo...
File chrome/browser/browsing_data_local_storage_helper_browsertest.cc (right):

http://codereview.chromium.org/8393036/diff/1/chrome/browser/browsing_data_lo...
chrome/browser/browsing_data_local_storage_helper_browsertest.cc:8: #include
"base/bind.h"
On 2011/10/26 17:40:56, csilv wrote:
> add bind_helpers.h

Done.

Expand Messages | Collapse Messages

Issue 8393036: base::Bind: Convert BrowsingDataLocalStorageHelper::StartFetching. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Build fix. #

Patch Set 3 : Review fix. #

Messages