Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Unified Diff: chrome/browser/browsing_data_local_storage_helper.cc

Issue 8393036: base::Bind: Convert BrowsingDataLocalStorageHelper::StartFetching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fix. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data_local_storage_helper.cc
diff --git a/chrome/browser/browsing_data_local_storage_helper.cc b/chrome/browser/browsing_data_local_storage_helper.cc
index a270f211b674b6202d185e8819ec6d9bce159362..8b84fc2c2e646905bb7538c1ee279bca44d69d21 100644
--- a/chrome/browser/browsing_data_local_storage_helper.cc
+++ b/chrome/browser/browsing_data_local_storage_helper.cc
@@ -48,7 +48,6 @@ BrowsingDataLocalStorageHelper::LocalStorageInfo::~LocalStorageInfo() {}
BrowsingDataLocalStorageHelper::BrowsingDataLocalStorageHelper(
Profile* profile)
: profile_(profile),
- completion_callback_(NULL),
is_fetching_(false) {
DCHECK(profile_);
}
@@ -57,12 +56,13 @@ BrowsingDataLocalStorageHelper::~BrowsingDataLocalStorageHelper() {
}
void BrowsingDataLocalStorageHelper::StartFetching(
- Callback1<const std::list<LocalStorageInfo>& >::Type* callback) {
+ const base::Callback<void(const std::list<LocalStorageInfo>&)>& callback) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(!is_fetching_);
- DCHECK(callback);
+ DCHECK_EQ(false, callback.is_null());
+
is_fetching_ = true;
- completion_callback_.reset(callback);
+ completion_callback_ = callback;
BrowserThread::PostTask(
BrowserThread::WEBKIT, FROM_HERE,
base::Bind(
@@ -72,7 +72,7 @@ void BrowsingDataLocalStorageHelper::StartFetching(
void BrowsingDataLocalStorageHelper::CancelNotification() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- completion_callback_.reset(NULL);
+ completion_callback_.Reset();
}
void BrowsingDataLocalStorageHelper::DeleteLocalStorageFile(
@@ -128,9 +128,9 @@ void BrowsingDataLocalStorageHelper::NotifyInUIThread() {
DCHECK(is_fetching_);
// Note: completion_callback_ mutates only in the UI thread, so it's safe to
// test it here.
- if (completion_callback_ != NULL) {
- completion_callback_->Run(local_storage_info_);
- completion_callback_.reset();
+ if (!completion_callback_.is_null()) {
+ completion_callback_.Run(local_storage_info_);
+ completion_callback_.Reset();
}
is_fetching_ = false;
}
@@ -178,12 +178,13 @@ bool CannedBrowsingDataLocalStorageHelper::empty() const {
}
void CannedBrowsingDataLocalStorageHelper::StartFetching(
- Callback1<const std::list<LocalStorageInfo>& >::Type* callback) {
+ const base::Callback<void(const std::list<LocalStorageInfo>&)>& callback) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(!is_fetching_);
- DCHECK(callback);
+ DCHECK_EQ(false, callback.is_null());
+
is_fetching_ = true;
- completion_callback_.reset(callback);
+ completion_callback_ = callback;
BrowserThread::PostTask(
BrowserThread::WEBKIT, FROM_HERE,
base::Bind(&CannedBrowsingDataLocalStorageHelper::
« no previous file with comments | « chrome/browser/browsing_data_local_storage_helper.h ('k') | chrome/browser/browsing_data_local_storage_helper_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698