Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: chrome/browser/ui/panels/panel_window_controller_cocoa.mm

Issue 8393014: Hack to fix Panel focus issues on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_window_controller_cocoa.mm
diff --git a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
index 036ed821ff7b131bc87f291f6ed90073353b262d..17cd841d71e06763b9749bf332af423671c10015 100644
--- a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
+++ b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
@@ -188,6 +188,10 @@ enum {
// Shows the window without making it key, on top of its layer, even if
// Chromium is not an active app.
[window orderFrontRegardless];
+ TabContents* tab_contents =
jennb 2011/10/26 17:48:09 Could you also add a comment explaining why we nee
+ windowShim_->panel()->browser()->GetSelectedTabContents();
+ DCHECK(tab_contents);
Dmitry Titov 2011/10/26 01:47:15 I would replace this DCHECK with if(). It can happ
jennb 2011/10/26 17:48:09 Yes, please replace with if() before committing. T
+ tab_contents->GetRenderWidgetHostView()->SetActive(false);
[window setFrame:frame display:YES animate:YES];
[contentView setAutoresizesSubviews:YES];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698