Hack to fix Panel focus issues on Mac.

chrome/browser/ui/panels/panel_window_controller_cocoa.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_window_controller_cocoa.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/logging.h"
 #include "base/mac/mac_util.h"
@@ skipping 170 matching lines @@
   NSView* contentView = [window contentView];
   [contentView setAutoresizesSubviews:NO];
 
   // We grow the window from the bottom up to produce a 'reveal' animation.
   NSRect startFrame = NSMakeRect(NSMinX(frame), NSMinY(frame),
                                  NSWidth(frame), kMinimumWindowSize);
   [window setFrame:startFrame display:NO animate:NO];
   // Shows the window without making it key, on top of its layer, even if
   // Chromium is not an active app.
   [window orderFrontRegardless];
+  TabContents* tab_contents =

[jennb, 2011/10/26 17:48:09]

Could you also add a comment explaining why we need to set RWHV !active upon
reveal?

+      windowShim_->panel()->browser()->GetSelectedTabContents();
+  DCHECK(tab_contents);

[Dmitry Titov, 2011/10/26 01:47:15]

I would replace this DCHECK with if(). It can happen (and happens) in tests that
we don't have tab content at all. Jennb knows more about it.

[jennb, 2011/10/26 17:48:09]

Yes, please replace with if() before committing. Thanks.

+  tab_contents->GetRenderWidgetHostView()->SetActive(false);
   [window setFrame:frame display:YES animate:YES];
 
   [contentView setAutoresizesSubviews:YES];
 }
 
 - (void)updateTitleBar {
   NSString* newTitle = base::SysUTF16ToNSString(
       windowShim_->browser()->GetWindowTitleForCurrentTab());
   pendingWindowTitle_.reset(
       [BrowserWindowUtils scheduleReplaceOldTitle:pendingWindowTitle_.get()
@@ skipping 351 matching lines @@
 - (BOOL)canBecomeKeyWindow {
   // Panel can only gain focus if it is expanded. Minimized panels do not
   // participate in Cmd-~ rotation.
   // TODO(dimich): If it will be ever desired to expand/focus the Panel on
   // keyboard navigation or via main menu, the care should be taken to avoid
   // cases when minimized Panel is getting keyboard input, invisibly.
   return windowShim_->panel()->expansion_state() == Panel::EXPANDED;
 }
 
 @end