Remove sync error button from bookmark bar

Remove sync error button from bookmark bar

We now show sync errors in the wrench menu so we no longer need to show in the bookmark bar.

BUG=101314
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107512

[sail, 2011-10-26 02:51:29]

atwilson, timsteele: sync
erg: GTK
pkasting: Views

[Elliot Glaysher, 2011-10-26 16:49:21]

gtk lgtm

[Peter Kasting, 2011-10-26 18:12:01]

Rubber-stamp LGTM, in that I assume there aren't more plumbing or utility pieces
that should also be removed

http://codereview.chromium.org/8391034/diff/1/chrome/browser/ui/gtk/bookmarks...
File chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc (right):

http://codereview.chromium.org/8391034/diff/1/chrome/browser/ui/gtk/bookmarks...
chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc:155:
browser->profile()->GetPrefs(), this);
Nit: Personal preference, but I'd use |browser_| instead of |browser| here

http://codereview.chromium.org/8391034/diff/1/chrome/browser/ui/views/bookmar...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right):

http://codereview.chromium.org/8391034/diff/1/chrome/browser/ui/views/bookmar...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:592: width +=
(other_bookmarked_pref.width() + kButtonPadding +
Nit: No parens needed

[Andrew T Wilson (Slow), 2011-10-26 18:36:07]

sync lgtm

[commit-bot: I haz the power, 2011-10-26 18:49:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8391034/1

[sail, 2011-10-27 00:45:54]

http://codereview.chromium.org/8391034/diff/1/chrome/browser/ui/views/bookmar...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right):

http://codereview.chromium.org/8391034/diff/1/chrome/browser/ui/views/bookmar...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:592: width +=
(other_bookmarked_pref.width() + kButtonPadding +
On 2011/10/26 18:12:01, Peter Kasting wrote:
> Nit: No parens needed

Done.

[commit-bot: I haz the power, 2011-10-27 00:46:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8391034/7001

[commit-bot: I haz the power, 2011-10-27 02:02:15]

Change committed as 107512