Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 8387070: Make non-templatized versions of LIR printing functions. (Closed)

Created:
9 years, 1 month ago by fschneider
Modified:
9 years, 1 month ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Make non-templatized versions of LIR printing functions. This avoid duplicating the code for each template instance. Also remove dead code from different places in our code base. Removed some verification code from release builds. Committed: http://code.google.com/p/v8/source/detail?r=9860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -94 lines) Patch
M src/code-stubs.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/hashmap.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/hashmap.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 6 chunks +10 lines, -19 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M src/scopes.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/scopes.cc View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 1 month ago (2011-11-01 14:19:01 UTC) #1
Rico
9 years, 1 month ago (2011-11-02 07:26:51 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698