Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 8387045: Make DeleteFramebuffer rebind fbo backbuffer (Closed)

Created:
9 years, 1 month ago by greggman
Modified:
9 years, 1 month ago
Reviewers:
alokp
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Make DeleteFramebuffer rebind fbo backbuffer Note: This is a kind of temporary fix. The fill fix is tracked in issue 102412 TEST=unit tests BUG=none R=alokp@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108070

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -10 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 6 chunks +25 lines, -6 lines 1 comment Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +4 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
Hey Alok, please review when you get a chance. This is a temp fix to ...
9 years, 1 month ago (2011-10-31 20:51:19 UTC) #1
alokp
lgtm Thanks for working on it! http://codereview.chromium.org/8387045/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): http://codereview.chromium.org/8387045/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode2180 gpu/command_buffer/service/gles2_cmd_decoder.cc:2180: GLenum target = ...
9 years, 1 month ago (2011-10-31 21:00:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/8387045/1
9 years, 1 month ago (2011-11-01 02:13:49 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-01 03:29:12 UTC) #4
Change committed as 108070

Powered by Google App Engine
This is Rietveld 408576698