Issue 8387036: Sync Promo: Suppress search bubble using host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8387036: Sync Promo: Suppress search bubble using host (Closed)

Created:
9 years, 1 month ago by sail

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Sync Promo: Suppress search bubble using host My code to suppress the first run search bubble wasn't working. The problem was that we were testing against the entire URL. Fix was to only care about the host. BUG=102392 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108007

Patch Set 1 #

Patch Set 2 : check scheme too #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/ui/browser.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages