Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2038)

Unified Diff: chrome/browser/ui/browser.cc

Issue 8387036: Sync Promo: Suppress search bubble using host (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: check scheme too Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index cfc396e0453c38130633ab23d54a35470fe3f8b1..54ac291b6f79653144450d16218a58e7203a2a02 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -5470,8 +5470,9 @@ void Browser::OnWindowDidShow() {
// Suppress the first run bubble if we're showing the sync promo.
TabContents* contents = GetSelectedTabContents();
- bool is_showing_promo =
- contents && contents->GetURL() == GURL(chrome::kChromeUISyncPromoURL);
+ bool is_showing_promo = contents &&
+ contents->GetURL().SchemeIs(chrome::kChromeUIScheme) &&
+ contents->GetURL().host() == chrome::kChromeUISyncPromoHost;
// Show the First Run information bubble if we've been told to.
PrefService* local_state = g_browser_process->local_state();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698