fix strings bug

member.dart

Index: member.dart
diff --git a/member.dart b/member.dart
index 22c9ff5eb2d60c05efeb8ce74d0bf28c3bb93702..7662074524be68918c79a2f270db08bd26b2b97b 100644
--- a/member.dart
+++ b/member.dart
@@ -1018,9 +1018,8 @@ class MethodMember extends Member {
             val1 = val1.substring(1, val1.length - 1);
           }
           var value = '${val0}${val1}';
-          var escapedValue = value.replaceAll('"', '\\"');
-          return new EvaluatedValue(world.stringType, value, '"$escapedValue"',
-              node.span);
+          value = '"' + value.replaceAll('"', '\\"') + '"';

[ahe, 2011/11/02 18:17:58]

What happens with these strings:

"\""
'\\"'

[jimhug, 2011/11/03 00:57:21]

This does seem to fix this issue - but I share Peter's puzzlement that this
works...

On 2011/11/02 18:17:58, ahe wrote:

[Siggi Cherem (dart-lang), 2011/11/03 17:31:28]

The issue is basically how we are representing strings as values. We tried to
preserve the original quotes in the value that it generates. Every compile-time
concatenation of strings is removing the quotes, concatenating the contents, and
putting the quotes back. 

Before this change, we weren't putting the quotes back.

Your examples will likely break right now, so I'll work on fixing that. I might
change the compiler to not include the quotes when parsing, or be more careful
about which quotes were used in val0/val1, and only escape strings when the
quotes differ.

[Jennifer Messerly, 2011/11/03 17:49:40]

+1 on normalizing strings in the tokenizer, rather than keeping them as quoted
values everywhere. I suspect a lot of string handling code will become simpler.

+          return new EvaluatedValue(world.stringType, value, value, node.span);
         }
 
         // Ensure we generate toString on the right side