fix strings bug

member.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** A formal parameter to a [Method]. */
 class Parameter {
   FormalNode definition;
 
   String name;
   Type type;
@@ skipping 1000 matching lines @@
         return new Value(declaringType, '${target.code}[${argsCode[0]}]');
       } else if (name == '\$add') {
         if (allConst) {
           var val0 = target.dynamic.actualValue;
           val0 = val0.substring(1, val0.length - 1);
           var val1 = args.values[0].dynamic.actualValue;
           if (args.values[0].type.isString) {
             val1 = val1.substring(1, val1.length - 1);
           }
           var value = '${val0}${val1}';
-          var escapedValue = value.replaceAll('"', '\\"');
-          return new EvaluatedValue(world.stringType, value, '"$escapedValue"',
-              node.span);
+          value = '"' + value.replaceAll('"', '\\"') + '"';

[ahe, 2011/11/02 18:17:58]

What happens with these strings:

"\""
'\\"'

[jimhug, 2011/11/03 00:57:21]

This does seem to fix this issue - but I share Peter's puzzlement that this
works...

On 2011/11/02 18:17:58, ahe wrote:

[Siggi Cherem (dart-lang), 2011/11/03 17:31:28]

The issue is basically how we are representing strings as values. We tried to
preserve the original quotes in the value that it generates. Every compile-time
concatenation of strings is removing the quotes, concatenating the contents, and
putting the quotes back. 

Before this change, we weren't putting the quotes back.

Your examples will likely break right now, so I'll work on fixing that. I might
change the compiler to not include the quotes when parsing, or be more careful
about which quotes were used in val0/val1, and only escape strings when the
quotes differ.

[Jennifer Messerly, 2011/11/03 17:49:40]

+1 on normalizing strings in the tokenizer, rather than keeping them as quoted
values everywhere. I suspect a lot of string handling code will become simpler.

+          return new EvaluatedValue(world.stringType, value, value, node.span);
         }
 
         // Ensure we generate toString on the right side
         args.values[0].invoke(world.gen, 'toString', node, Arguments.EMPTY);
         return new Value(declaringType, '${target.code} + ${argsCode[0]}');
       }
     } else if (declaringType.isNativeType) {
       if (name == '\$index') {
         // Note: this could technically propagate constness, but that's not
         // specified explicitly and the VM doesn't do that.
@@ skipping 368 matching lines @@
   }
 
   void forEach(void f(MethodMember member)) {
     factories.forEach((_, Map constructors) {
       constructors.forEach((_, Member member) {
         f(member);
       });
     });
   }
 }