Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: tests/standalone/src/EchoServerStreamTest.dart

Issue 8386029: Consistently use setters to set event handlers in native APIs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/src/DirectoryTest.dart ('k') | tests/standalone/src/EchoServerTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/EchoServerStreamTest.dart
diff --git a/tests/standalone/src/EchoServerStreamTest.dart b/tests/standalone/src/EchoServerStreamTest.dart
index cb96be03b645fce30880d975b2b859e9b9908105..7bae9078bf92add866c650737b39ede132ac7521 100644
--- a/tests/standalone/src/EchoServerStreamTest.dart
+++ b/tests/standalone/src/EchoServerStreamTest.dart
@@ -90,15 +90,15 @@ class EchoServerGame {
inputStream.dataHandler = dataReceived;
}
- _socket.setCloseHandler(closeHandler);
- _socket.setErrorHandler(errorHandler);
+ _socket.closeHandler = closeHandler;
+ _socket.errorHandler = errorHandler;
stream.write(_buffer);
dataSent();
}
_socket = new Socket(EchoServer.HOST, _port);
if (_socket !== null) {
- _socket.setConnectHandler(connectHandler);
+ _socket.connectHandler = connectHandler;
} else {
Expect.fail("socket creation failed");
}
@@ -164,8 +164,8 @@ class EchoServer extends Isolate {
_client = _server.accept();
inputStream = _client.inputStream;
inputStream.dataHandler = dataReceived;
- _client.setCloseHandler(closeHandler);
- _client.setErrorHandler(errorHandler);
+ _client.closeHandler = closeHandler;
+ _client.errorHandler = errorHandler;
}
void errorHandlerServer() {
@@ -177,8 +177,8 @@ class EchoServer extends Isolate {
if (message == EchoServerGame.SERVERINIT) {
_server = new ServerSocket(HOST, 0, 10);
Expect.equals(true, _server !== null);
- _server.setConnectionHandler(connectionHandler);
- _server.setErrorHandler(errorHandlerServer);
+ _server.connectionHandler = connectionHandler;
+ _server.errorHandler = errorHandlerServer;
replyTo.send(_server.port, null);
} else if (message == EchoServerGame.SERVERSHUTDOWN) {
_server.close();
« no previous file with comments | « tests/standalone/src/DirectoryTest.dart ('k') | tests/standalone/src/EchoServerTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698